8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak

[cost0much]

Clean backport that makes TestListenerLeak more robust; already backported to 11, 17 and 21. Not clean because 8 file structure. Passes affected test on Linux x64.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8316193 needs maintainer approval

Issue

• JDK-8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak (Bug - P4 - Approved)

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/574/head:pull/574
$ git checkout pull/574

Update a local copy of the PR:
$ git checkout pull/574
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/574/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 574

View PR using the GUI difftool:
$ git pr show -t 574

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/574.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cost0much This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• 8b08668: 8250825: C2 crashes with assert(field != __null) failed: missing field
• bfd4d8b: 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo
• f89c26f: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
• 492acd3: 8265019: Update tests for additional TestNG test permissions
• 3683a81: Merge
• 129290d: 8339180: Enhanced Building of Processes: Follow-on Issue
• c2f7e61: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
• 2d042cf: 8336564: Enhance mask blit functionality redux
• 1a447c7: 8335428: Enhanced Building of Processes
• 1a6e3a5: 8342822: jdk8u432-b06 does not compile on AIX
• ... and 27 more: https://git.openjdk.org/jdk8u-dev/compare/42c6c17c2e3e19a518cabe0064cbdbf12fc5d40f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (69230332)

[openjdk]

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[cost0much]

/approval request Improves the jfr TestListenerLeak test. Applies cleanly. Affected test passes. Risk is low: the change is test code only.

[openjdk]

@cost0much
8316193: The approval request has been created successfully.

[bridgekeeper]

@cost0much This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@cost0much This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[cost0much]

/open

[openjdk]

@cost0much This pull request is now open

[cost0much]

/integrate

[openjdk]

@cost0much
Your change (at version 6923033) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 4c50940.
Since your change was applied there have been 37 commits pushed to the master branch:

• 8b08668: 8250825: C2 crashes with assert(field != __null) failed: missing field
• bfd4d8b: 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo
• f89c26f: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
• 492acd3: 8265019: Update tests for additional TestNG test permissions
• 3683a81: Merge
• 129290d: 8339180: Enhanced Building of Processes: Follow-on Issue
• c2f7e61: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
• 2d042cf: 8336564: Enhance mask blit functionality redux
• 1a447c7: 8335428: Enhanced Building of Processes
• 1a6e3a5: 8342822: jdk8u432-b06 does not compile on AIX
• ... and 27 more: https://git.openjdk.org/jdk8u-dev/compare/42c6c17c2e3e19a518cabe0064cbdbf12fc5d40f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @cost0much Pushed as commit 4c50940.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.