Skip to content

Conversation

@zzambers
Copy link
Contributor

@zzambers zzambers commented Oct 1, 2024

Only affects GHA. Not a clean backport because gha workflows have been rewritten in newer jdks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8338402 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8338402: GHA: some of bundles may not get removed (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/586/head:pull/586
$ git checkout pull/586

Update a local copy of the PR:
$ git checkout pull/586
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/586/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 586

View PR using the GUI difftool:
$ git pr show -t 586

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/586.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2024

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8338402: GHA: some of bundles may not get removed

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 6acc668: 8209023: fix 2 compiler tests to avoid JDK-8208690
  • 61a4127: 8251188: Update LDAP tests not to use wildcard addresses
  • b4264bc: 8340815: Add SECURITY.md file
  • 13e86fb: Merge
  • 39221f8: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport d8e4d3f2d6c187f2487acd390a4e5fa2a99010ea 8338402: GHA: some of bundles may not get removed Oct 1, 2024
@openjdk
Copy link

openjdk bot commented Oct 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 1, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2024

Webrevs

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please apply for approval.

@openjdk
Copy link

openjdk bot commented Oct 2, 2024

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@zzambers
Copy link
Contributor Author

zzambers commented Oct 2, 2024

/approval request Fix/improvement to GHA code, which removes bundles, only affects GHA, tested

@openjdk
Copy link

openjdk bot commented Oct 2, 2024

@zzambers
8338402: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 2, 2024
@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Oct 3, 2024

@gnu-andrew
8338402: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 3, 2024
@zzambers
Copy link
Contributor Author

zzambers commented Oct 3, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 3, 2024

Going to push as commit 5b8dfbb.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 02b8101: 8341059: Change Entrust TLS distrust date to November 12, 2024
  • 6acc668: 8209023: fix 2 compiler tests to avoid JDK-8208690
  • 61a4127: 8251188: Update LDAP tests not to use wildcard addresses
  • b4264bc: 8340815: Add SECURITY.md file
  • 13e86fb: Merge
  • 39221f8: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 3, 2024
@openjdk openjdk bot closed this Oct 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 3, 2024
@openjdk
Copy link

openjdk bot commented Oct 3, 2024

@zzambers Pushed as commit 5b8dfbb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants