Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285523: Improve test java/io/FileOutputStream/OpenNUL.java #59

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented May 16, 2022

Hi all,
This pull request contains a backport of commit f42631e3 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 29 Apr 2022 and was reviewed by Andrew John Hughes and Brian Burkhalter.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285523: Improve test java/io/FileOutputStream/OpenNUL.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/59/head:pull/59
$ git checkout pull/59

Update a local copy of the PR:
$ git checkout pull/59
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/59/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 59

View PR using the GUI difftool:
$ git pr show -t 59

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/59.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 16, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mrserb mrserb changed the title git commit -m 'Backport f42631e354d4abf7994abd92aa5def6b2ceeab3a' Backport f42631e354d4abf7994abd92aa5def6b2ceeab3a May 16, 2022
@openjdk openjdk bot changed the title Backport f42631e354d4abf7994abd92aa5def6b2ceeab3a 8285523: Improve test java/io/FileOutputStream/OpenNUL.java May 16, 2022
@openjdk
Copy link

openjdk bot commented May 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 16, 2022
@mrserb
Copy link
Member Author

mrserb commented May 16, 2022

/clean only the path is changed

@openjdk openjdk bot added the clean label May 16, 2022
@openjdk
Copy link

openjdk bot commented May 16, 2022

@mrserb This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented May 16, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285523: Improve test java/io/FileOutputStream/OpenNUL.java

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 3e0eb09: 8248876: LoadObject with bad base address created for exec file on linux
  • 6b94b65: 8278138: OpenJDK8 fails to start on Windows 8.1 after upgrading compiler to VS2017
  • 680b09c: 8168926: C2: Bytecode escape analyzer crashes due to stack overflow

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 16, 2022
@mrserb mrserb marked this pull request as ready for review May 16, 2022 01:44
@openjdk openjdk bot added the rfr Pull request is ready for review label May 16, 2022
@mlbridge
Copy link

mlbridge bot commented May 16, 2022

Webrevs

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for 8u

@mrserb
Copy link
Member Author

mrserb commented May 24, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 24, 2022

Going to push as commit db52470.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 3e0eb09: 8248876: LoadObject with bad base address created for exec file on linux
  • 6b94b65: 8278138: OpenJDK8 fails to start on Windows 8.1 after upgrading compiler to VS2017
  • 680b09c: 8168926: C2: Bytecode escape analyzer crashes due to stack overflow

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 24, 2022
@openjdk openjdk bot closed this May 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 24, 2022
@openjdk
Copy link

openjdk bot commented May 24, 2022

@mrserb Pushed as commit db52470.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8285523 branch May 24, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants