8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9 #594

kurashige23 · 2024-10-11T08:56:05Z

The following tests fail when they cannot find the NSS version information, because the initial value of nss_ecc_status is ECCState.Extended and tries to use the EC algorithm not supported in ECCState.Basic,

sun/security/pkcs11/ec/TestECDH.java
sun/security/pkcs11/ec/TestECDSA.java
sun/security/pkcs11/ec/TestECGenSpec.java

To resolve these failures, change the initial value of nss_ecc_status from ECCState.Extended to ECCState.Basic.

Similar fix was made in JDK-8253637 for jdk16 and later, and JDK-8328889 for jdk11.

JDK-8253637 and JDK-8313206 were done with versions higher than jdk8. For this reason, it is normal to do a backport, but do not backport to jdk11 or jdk8 because:

JDK-8253637
About jdk11
・The ECDHKeyAgreement.java diff contains enhancements that have not been applied to jdk11 and cannot be backported to jdk11.
・Since TestEC.java is now passed in jdk11 and has been removed from the ProblemList, there is no need to modify Problemlist.txt and TestEC.java.
・The fix for PKCS11Test.java has already been made in JDK-8313206.
About jdk8
・For the same reason as jdk11, the ECDHKeyAgreement.java diff is not applicable, and the TestEC.java and Problemlist.txt diffs need not be applied.
・All we need is a PKCS11Test.java fix to resolve 3 failures (TestECDH.java, TestECDSA.java and TestECGenSpec.java). It is appropriate to issue a new bug ID this time because the test to be solved is different from JDK-8253637.

JDK-8313206
In JDK-8313206, only jdk11 has the fix to the initial value of nss_ecc_status in PKCS11Test.java.
Since JDK-8313206 is a different topic than the one I want to solve this time, I think it is inappropriate to backport to solve 3 failures(TestECDH.java, TestECDSA.java and TestECGenSpec.java).

Thanks

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8341946 needs maintainer approval

Issue

JDK-8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9 (Bug - P4 - Approved)

Reviewers

Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/594/head:pull/594
$ git checkout pull/594

Update a local copy of the PR:
$ git checkout pull/594
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/594/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 594

View PR using the GUI difftool:
$ git pr show -t 594

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/594.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2024-10-11T08:56:26Z

👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-10-11T08:56:45Z

@kurashige23 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

7912413: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte
8c4a65b: 8351098: Bump update version of OpenJDK: 8u462
6a7d893: 8350816: [8u] Update TzdbZoneRulesCompiler to ignore HST/EST/MST links
8f8531c: 8285756: clean up use of bad arguments for @clean in langtools tests
24cade6: 8340552: Harden TzdbZoneRulesCompiler against missing zone names
898e131: 8261020: Wrong format parameter in create_emergency_chunk_path
0b5a2e7: 8346140: [8u] tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1
8eccf89: 8340660: [8u] Test com/sun/jdi/PrivateTransportTest.sh fails on MacOS
85fb26b: 8244966: Add .vscode to .hgignore and .gitignore
5ccff2c: 8348211: [8u] sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport of JDK-8066708
... and 41 more: https://git.openjdk.org/jdk8u-dev/compare/42c6c17c2e3e19a518cabe0064cbdbf12fc5d40f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

mlbridge · 2024-10-11T09:00:51Z

Webrevs

00: Full (a1698cd6)

kurashige23 · 2024-10-25T04:39:00Z

Could anyone review this backport please?

openjdk · 2024-10-28T14:49:12Z

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

kurashige23 · 2024-10-29T01:08:42Z

/approval request Fix the test failure in TestECDH.java, TestECDSA.java and TestECGenSpec.java on RHEL9. Risk is low, test-only fix. pkcs11 tests on RHEL9 and GHA tests pass.

openjdk · 2024-10-29T01:09:13Z

@kurashige23
8341946: The approval request has been created successfully.

kurashige23 · 2024-11-12T13:10:52Z

@phohensee

If you have time, I would like you to confirm my fix request.
Thanks.

phohensee · 2024-11-12T23:33:37Z

@gnu-andrew, would you please take a look?

kurashige23 · 2024-12-10T23:30:50Z

@gnu-andrew
I'm sorry, but if you have time, I would appreciate it if you could check it.

bridgekeeper · 2025-01-07T23:45:15Z

@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

kurashige23 · 2025-01-07T23:57:53Z

Comment to avoid automatic close.

bridgekeeper · 2025-02-05T02:46:38Z

@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

kurashige23 · 2025-02-05T23:45:08Z

@gnu-andrew

I'm sorry, but if you have time, I would appreciate it if you could check it.

bridgekeeper · 2025-03-06T02:39:34Z

@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

kurashige23 · 2025-03-07T04:53:14Z

@theRealAph @jerboaa

I apologize for the inconvenience, but I would appreciate it if you could take a moment to review this fix.

kurashige23 · 2025-03-11T00:07:10Z

/integrate

openjdk · 2025-03-11T00:08:02Z

@kurashige23
Your change (at version a1698cd) is now ready to be sponsored by a Committer.

phohensee · 2025-03-11T18:55:00Z

/sponsor

openjdk · 2025-03-11T18:55:19Z

Going to push as commit 84576a9.
Since your change was applied there have been 51 commits pushed to the master branch:

7912413: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte
8c4a65b: 8351098: Bump update version of OpenJDK: 8u462
6a7d893: 8350816: [8u] Update TzdbZoneRulesCompiler to ignore HST/EST/MST links
8f8531c: 8285756: clean up use of bad arguments for @clean in langtools tests
24cade6: 8340552: Harden TzdbZoneRulesCompiler against missing zone names
898e131: 8261020: Wrong format parameter in create_emergency_chunk_path
0b5a2e7: 8346140: [8u] tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1
8eccf89: 8340660: [8u] Test com/sun/jdi/PrivateTransportTest.sh fails on MacOS
85fb26b: 8244966: Add .vscode to .hgignore and .gitignore
5ccff2c: 8348211: [8u] sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport of JDK-8066708
... and 41 more: https://git.openjdk.org/jdk8u-dev/compare/42c6c17c2e3e19a518cabe0064cbdbf12fc5d40f...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-03-11T18:55:30Z

@phohensee @kurashige23 Pushed as commit 84576a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

kurashige23 added 2 commits October 10, 2024 14:47

Change the initial value of nss_ecc_status

c2a8ed6

Modify copyright year

a1698cd

kurashige23 changed the title ~~JDK-8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9~~ 8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9 Oct 11, 2024

openjdk bot added the rfr Pull request is ready for review label Oct 11, 2024

phohensee approved these changes Oct 28, 2024

View reviewed changes

openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 29, 2024

openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 10, 2025

openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 11, 2025

openjdk bot added the integrated Pull request has been integrated label Mar 11, 2025

openjdk bot closed this Mar 11, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 11, 2025

8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9 #594

8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9 #594

Uh oh!

Conversation

kurashige23 commented Oct 11, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Oct 11, 2024

Uh oh!

openjdk bot commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Oct 11, 2024

Webrevs

Uh oh!

kurashige23 commented Oct 25, 2024

Uh oh!

openjdk bot commented Oct 28, 2024

Uh oh!

kurashige23 commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Oct 29, 2024

Uh oh!

kurashige23 commented Nov 12, 2024

Uh oh!

phohensee commented Nov 12, 2024

Uh oh!

kurashige23 commented Dec 10, 2024

Uh oh!

bridgekeeper bot commented Jan 7, 2025

Uh oh!

kurashige23 commented Jan 7, 2025

Uh oh!

bridgekeeper bot commented Feb 5, 2025

Uh oh!

kurashige23 commented Feb 5, 2025

Uh oh!

bridgekeeper bot commented Mar 6, 2025

Uh oh!

kurashige23 commented Mar 7, 2025

Uh oh!

kurashige23 commented Mar 11, 2025

Uh oh!

openjdk bot commented Mar 11, 2025

Uh oh!

phohensee commented Mar 11, 2025

Uh oh!

openjdk bot commented Mar 11, 2025

Uh oh!

openjdk bot commented Mar 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

kurashige23 commented Oct 11, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Oct 11, 2024 •

edited

Loading

kurashige23 commented Oct 29, 2024 •

edited

Loading