Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8195675: Call to insertText with single character from custom Input Method ignored #595

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 16, 2024

Hi all,

This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository.

The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race.
PR was openjdk/jdk#17921

Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8195675 needs maintainer approval

Issue

  • JDK-8195675: Call to insertText with single character from custom Input Method ignored (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/595/head:pull/595
$ git checkout pull/595

Update a local copy of the PR:
$ git checkout pull/595
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/595/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 595

View PR using the GUI difftool:
$ git pr show -t 595

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/595.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2024

👋 Welcome back srl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 16, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd 8195675: Call to insertText with single character from custom Input Method ignored Oct 16, 2024
@openjdk
Copy link

openjdk bot commented Oct 16, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 16, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2024

Webrevs

@openjdk openjdk bot added the approval label Oct 16, 2024
@srl295
Copy link
Member Author

srl295 commented Oct 16, 2024

/approval

@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@srl295 usage: /approval [<id>] (request|cancel) [<text>]

@srl295
Copy link
Member Author

srl295 commented Oct 16, 2024

/approval request java.awt components did not work properly on macOS with custom input methods, the net effect is that minority language keyboards did not work properly with Java. Low risk, the fix handles this situation similarly to how Apple's own 'kotoeri' input method was handled on a long term basis, so it is a well-worn path. Patch should apply cleanly and was code reviewed

@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@srl295
8195675: The approval request has been created successfully.

- This change turned out to depend on 8214578
- Backport of openjdk/jdk@0b0a33e for the kbdLayout
- also see openjdk/jdk@02bbbb4
@openjdk openjdk bot removed the rfr Pull request is ready for review label Oct 25, 2024
@srl295
Copy link
Member Author

srl295 commented Oct 25, 2024

Hm. Needed another commit with JDK-8214578 to build. Doesn't seem to work yet. I'll try other versions.

@srl295
Copy link
Member Author

srl295 commented Oct 25, 2024

Oh, actually it does work! I just needed to follow instructions for the keyboard and restart first.

Example of jEdit with the fix:

image

Without the fix:

image

( jEdit 5.2pre1, typing ji and naan and kala )

@srl295
Copy link
Member Author

srl295 commented Oct 25, 2024

failures seem to be certificate related

FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 25, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 23, 2024

@srl295 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@srl295
Copy link
Member Author

srl295 commented Nov 23, 2024

I need help with the 8u request tag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant