8195675: Call to insertText with single character from custom Input Method ignored

[srl295]

Hi all,

This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository.

The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race.
PR was openjdk/jdk#17921

Additionally, it needed a partial backport of the following two:

• openjdk/jdk@0b0a33e for the kbdLayout
• openjdk/jdk@02bbbb4 for a type change

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8195675 needs maintainer approval

Issue

• JDK-8195675: Call to insertText with single character from custom Input Method ignored (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/595/head:pull/595
$ git checkout pull/595

Update a local copy of the PR:
$ git checkout pull/595
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/595/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 595

View PR using the GUI difftool:
$ git pr show -t 595

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/595.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back srl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 04: Full - Incremental (d3b3d460)
• 03: Full - Incremental (4fea7954)
• 02: Full - Incremental (2a337e89)
• 01: Full - Incremental (180a8895)
• 00: Full (12204c2d)

[srl295]

/approval

[openjdk]

@srl295 usage: /approval [<id>] (request|cancel) [<text>]

[srl295]

/approval request java.awt components did not work properly on macOS with custom input methods, the net effect is that minority language keyboards did not work properly with Java. Low risk, the fix handles this situation similarly to how Apple's own 'kotoeri' input method was handled on a long term basis, so it is a well-worn path. Patch should apply cleanly and was code reviewed

[openjdk]

@srl295
8195675: The approval request has been created successfully.

[srl295]

Hm. Needed another commit with JDK-8214578 to build. Doesn't seem to work yet. I'll try other versions.

[srl295]

Oh, actually it does work! I just needed to follow instructions for the keyboard and restart first.

Example of jEdit with the fix:

Without the fix:

( jEdit 5.2pre1, typing ji and naan and kala )

[srl295]

failures seem to be certificate related

FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4

[bridgekeeper]

@srl295 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[srl295]

I need help with the 8u request tag!

[srl295]

@srl295 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

I need help with 8-request triaging

[bridgekeeper]

@srl295 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[srl295]

Ping?

[jerboaa]

This needs a review before being eligible for approval. Removing the request tag meanwhile.

[srl295]

OK - how do I apply for that review?

[jerboaa]

OK - how do I apply for that review?

Find somebody with expertise in this area and perhaps also somebody who is a reviewer in JDK 8u project. Perhaps @mrserb can help?

[srl295]

Oh you mean a PR review … Not a ticket review.

@prrace

[bridgekeeper]

@srl295 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[srl295]

Ping..

[srl295]

I get failures when trying to build master on my own fork also. So i'm not sure these are related.

[bridgekeeper]

@srl295 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@srl295 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.