-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8195675: Call to insertText with single character from custom Input Method ignored #595
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back srl! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
/approval |
@srl295 usage: |
/approval request java.awt components did not work properly on macOS with custom input methods, the net effect is that minority language keyboards did not work properly with Java. Low risk, the fix handles this situation similarly to how Apple's own 'kotoeri' input method was handled on a long term basis, so it is a well-worn path. Patch should apply cleanly and was code reviewed |
- This change turned out to depend on 8214578 - Backport of openjdk/jdk@0b0a33e for the kbdLayout - also see openjdk/jdk@02bbbb4
Hm. Needed another commit with JDK-8214578 to build. Doesn't seem to work yet. I'll try other versions. |
failures seem to be certificate related
|
@srl295 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
I need help with the 8u request tag! |
Hi all,
This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository.
The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race.
PR was openjdk/jdk#17921
Thanks
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/595/head:pull/595
$ git checkout pull/595
Update a local copy of the PR:
$ git checkout pull/595
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/595/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 595
View PR using the GUI difftool:
$ git pr show -t 595
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/595.diff
Using Webrev
Link to Webrev Comment