-
Notifications
You must be signed in to change notification settings - Fork 171
8342841: [8u] Separate jdk_security_infra tests from jdk_tier1 #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into |
|
@zzambers This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me.
|
|
|
/approval request separates jdk_security_infra from jdk_tier1 and makes separate cases for it in GHA, affects testing only, GHA ok |
|
/approve yes |
|
@jerboaa |
|
/integrate |
|
Going to push as commit ed3d731.
Your commit was automatically rebased without conflicts. |
After JDK-8315757,
jdk_security_infrais included injdk_tier1(jdk 8 only). I would like to exclude it fromjdk_tier1and instead add new configurations to GHA workflow.Motivations:
jdk_security_infrahas not proven to be very stable/reliable set of tests.jdk_security_infratest failures from other tests failures in results would be helpfuljdk_security_infraare created to work with internal cacerts, but vendors usually replace cacerts with their own (e.g. temurin). It then complicates runningjdk_tier1group on jdk with custom cacerts (needs custom excludes etc..).jdk_security_infrainjdk_tier1Testing:
GHA: OK (all test failures should be unrelated to this change)
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/596/head:pull/596$ git checkout pull/596Update a local copy of the PR:
$ git checkout pull/596$ git pull https://git.openjdk.org/jdk8u-dev.git pull/596/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 596View PR using the GUI difftool:
$ git pr show -t 596Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/596.diff
Using Webrev
Link to Webrev Comment