Skip to content

Conversation

@zzambers
Copy link
Contributor

@zzambers zzambers commented Oct 22, 2024

After JDK-8315757, jdk_security_infra is included in jdk_tier1 (jdk 8 only). I would like to exclude it from jdk_tier1 and instead add new configurations to GHA workflow.

Motivations:

  • jdk_security_infra has not proven to be very stable/reliable set of tests.
  • being able to quickly distinguish jdk_security_infra test failures from other tests failures in results would be helpful
  • tests in jdk_security_infra are created to work with internal cacerts, but vendors usually replace cacerts with their own (e.g. temurin). It then complicates running jdk_tier1 group on jdk with custom cacerts (needs custom excludes etc..).
  • jdk 8 is currently only jdk including jdk_security_infra in jdk_tier1

Testing:
GHA: OK (all test failures should be unrelated to this change)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8342841 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8342841: [8u] Separate jdk_security_infra tests from jdk_tier1 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/596/head:pull/596
$ git checkout pull/596

Update a local copy of the PR:
$ git checkout pull/596
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/596/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 596

View PR using the GUI difftool:
$ git pr show -t 596

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/596.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2024

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 22, 2024

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8342841: [8u] Separate jdk_security_infra tests from jdk_tier1

Reviewed-by: sgehwolf, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 1d2f467: 8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows
  • 41f479c: 8133287: (fs) java/nio/file/Files/probeContentType/ParallelProbes.java should use othervm mode
  • 7e1ea51: 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method
  • 31b8804: Merge
  • 618917e: 8341059: Change Entrust TLS distrust date to November 12, 2024
  • 1c1afe3: 8341057: Add 2 SSL.com TLS roots
  • e976b99: 8335713: Enhance vectorization analysis
  • c5508ab: 8332644: Improve graph optimizations
  • da6b265: 8290367: Update default value and extend the scope of com.sun.jndi.ldap.object.trustSerialData system property
  • 3b077b8: 8331446: Improve deserialization support
  • ... and 9 more: https://git.openjdk.org/jdk8u-dev/compare/42c6c17c2e3e19a518cabe0064cbdbf12fc5d40f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 22, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 22, 2024

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@openjdk
Copy link

openjdk bot commented Oct 24, 2024

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@zzambers
Copy link
Contributor Author

/approval request separates jdk_security_infra from jdk_tier1 and makes separate cases for it in GHA, affects testing only, GHA ok

@openjdk
Copy link

openjdk bot commented Oct 24, 2024

@zzambers
8342841: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 24, 2024
@jerboaa
Copy link
Contributor

jerboaa commented Nov 7, 2024

/approve yes

@openjdk
Copy link

openjdk bot commented Nov 7, 2024

@jerboaa
8342841: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 7, 2024
@zzambers
Copy link
Contributor Author

zzambers commented Nov 7, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Nov 7, 2024

Going to push as commit ed3d731.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 1d2f467: 8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows
  • 41f479c: 8133287: (fs) java/nio/file/Files/probeContentType/ParallelProbes.java should use othervm mode
  • 7e1ea51: 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method
  • 31b8804: Merge
  • 618917e: 8341059: Change Entrust TLS distrust date to November 12, 2024
  • 1c1afe3: 8341057: Add 2 SSL.com TLS roots
  • e976b99: 8335713: Enhance vectorization analysis
  • c5508ab: 8332644: Improve graph optimizations
  • da6b265: 8290367: Update default value and extend the scope of com.sun.jndi.ldap.object.trustSerialData system property
  • 3b077b8: 8331446: Improve deserialization support
  • ... and 9 more: https://git.openjdk.org/jdk8u-dev/compare/42c6c17c2e3e19a518cabe0064cbdbf12fc5d40f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 7, 2024
@openjdk openjdk bot closed this Nov 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 7, 2024
@openjdk
Copy link

openjdk bot commented Nov 7, 2024

@zzambers Pushed as commit ed3d731.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants