8343334: JFR crash in JfrEmergencyDump::build_dump_path #599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expect a string value but actually pass an integer value to
jio_snprintfwhich could lead to undefined behavior.The minor result is the error JFR file path, the major result is JVM crash.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/599/head:pull/599$ git checkout pull/599Update a local copy of the PR:
$ git checkout pull/599$ git pull https://git.openjdk.org/jdk8u-dev.git pull/599/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 599View PR using the GUI difftool:
$ git pr show -t 599Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/599.diff
Using Webrev
Link to Webrev Comment