Skip to content

Conversation

@lingjun-cg
Copy link
Contributor

@lingjun-cg lingjun-cg commented Oct 31, 2024

Expect a string value but actually pass an integer value to jio_snprintf which could lead to undefined behavior.
The minor result is the error JFR file path, the major result is JVM crash.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8343334 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343334: JFR crash in JfrEmergencyDump::build_dump_path (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/599/head:pull/599
$ git checkout pull/599

Update a local copy of the PR:
$ git checkout pull/599
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/599/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 599

View PR using the GUI difftool:
$ git pr show -t 599

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/599.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2024

👋 Welcome back lingjun-cg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 31, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 31, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 31, 2024

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you just backport JDK-8261020?

@lingjun-cg
Copy link
Contributor Author

lingjun-cg commented Nov 6, 2024

Can't you just backport JDK-8261020?

OK. The new backport PR : 8261020: Wrong format parameter in create_emergency_chunk_path

@lingjun-cg lingjun-cg closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants