-
Notifications
You must be signed in to change notification settings - Fork 162
8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@zzambers This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @jerboaa) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Same patch as for 11u.
@jerboaa @phohensee thanks for reviews |
/integrate |
/sponsor |
Going to push as commit b5bcf6c. |
please review this backport.
It fixes: test/com/sun/jdi/RedefineCrossEvent.java test.
I manually ran all tests in test/com/sun/jdi and they passed for me with this patch applied (when originally created).
This is PR for backport posted to jdk8u-dev just before move to github:
https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-February/014578.html
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/6/head:pull/6
$ git checkout pull/6
Update a local copy of the PR:
$ git checkout pull/6
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/6/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6
View PR using the GUI difftool:
$ git pr show -t 6
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/6.diff