Skip to content

8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Mar 14, 2022

please review this backport.
It fixes: test/com/sun/jdi/RedefineCrossEvent.java test.
I manually ran all tests in test/com/sun/jdi and they passed for me with this patch applied (when originally created).

This is PR for backport posted to jdk8u-dev just before move to github:
https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-February/014578.html


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/6/head:pull/6
$ git checkout pull/6

Update a local copy of the PR:
$ git checkout pull/6
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/6/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6

View PR using the GUI difftool:
$ git pr show -t 6

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/6.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 14, 2022

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@zzambers zzambers changed the title backport 8279669 Backport 4c52eb39431c2479b0d140907bdcc0311d30f871 Mar 14, 2022
@openjdk openjdk bot changed the title Backport 4c52eb39431c2479b0d140907bdcc0311d30f871 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition Mar 14, 2022
@openjdk
Copy link

openjdk bot commented Mar 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 14, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 14, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Mar 14, 2022

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition

Reviewed-by: phh, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 14, 2022
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Same patch as for 11u.

@zzambers
Copy link
Contributor Author

@jerboaa @phohensee thanks for reviews

@zzambers
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 15, 2022
@openjdk
Copy link

openjdk bot commented Mar 15, 2022

@zzambers
Your change (at version f3c5fda) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Mar 15, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 15, 2022

Going to push as commit b5bcf6c.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 15, 2022
@openjdk openjdk bot closed this Mar 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 15, 2022
@openjdk
Copy link

openjdk bot commented Mar 15, 2022

@jerboaa @zzambers Pushed as commit b5bcf6c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants