8285756: clean up use of bad arguments for @clean in langtools tests

[satyenme]

Backporting JDK-8285756: clean up use of bad arguments for @clean in langtools tests. This adjusts test tags to be compatible with newer versions of jtreg. Backport is not clean due to not having some of the newer tests, and not providing the --source 8 arg. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8285756 needs maintainer approval

Issue

• JDK-8285756: clean up use of bad arguments for @<!---->clean in langtools tests (Bug - P3 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/618/head:pull/618
$ git checkout pull/618

Update a local copy of the PR:
$ git checkout pull/618
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/618/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 618

View PR using the GUI difftool:
$ git pr show -t 618

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/618.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@satyenme This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285756: clean up use of bad arguments for `@clean` in langtools tests

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 24cade6: 8340552: Harden TzdbZoneRulesCompiler against missing zone names
• 898e131: 8261020: Wrong format parameter in create_emergency_chunk_path
• 0b5a2e7: 8346140: [8u] tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1
• 8eccf89: 8340660: [8u] Test com/sun/jdi/PrivateTransportTest.sh fails on MacOS
• 85fb26b: 8244966: Add .vscode to .hgignore and .gitignore
• 5ccff2c: 8348211: [8u] sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport of JDK-8066708
• f5e9a25: 8349166: Bad indentation in backport of JDK-8250825
• fc88d51: 8255466: C2 crashes at ciObject::get_oop() const+0x0
• 88a7829: 8339644: Improve parsing of Day/Month in tzdata rules
• 4c50940: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• ... and 10 more: https://git.openjdk.org/jdk8u-dev/compare/5a4b44089f3f95b92620ef3a7b49f2390b70afaa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (34c19cf1)

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[satyenme]

/approval request fixes test tags to work with newer jtreg, low risk, only affects test code, tested OK

[openjdk]

@satyenme
8285756: The approval request has been created successfully.

[bridgekeeper]

@satyenme This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[satyenme]

/integrate

[openjdk]

@satyenme
Your change (at version 34c19cf) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 8f8531c.
Since your change was applied there have been 20 commits pushed to the master branch:

• 24cade6: 8340552: Harden TzdbZoneRulesCompiler against missing zone names
• 898e131: 8261020: Wrong format parameter in create_emergency_chunk_path
• 0b5a2e7: 8346140: [8u] tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1
• 8eccf89: 8340660: [8u] Test com/sun/jdi/PrivateTransportTest.sh fails on MacOS
• 85fb26b: 8244966: Add .vscode to .hgignore and .gitignore
• 5ccff2c: 8348211: [8u] sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport of JDK-8066708
• f5e9a25: 8349166: Bad indentation in backport of JDK-8250825
• fc88d51: 8255466: C2 crashes at ciObject::get_oop() const+0x0
• 88a7829: 8339644: Improve parsing of Day/Month in tzdata rules
• 4c50940: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• ... and 10 more: https://git.openjdk.org/jdk8u-dev/compare/5a4b44089f3f95b92620ef3a7b49f2390b70afaa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @satyenme Pushed as commit 8f8531c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.