Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 23, 2025

Follow-up fix for JDK-8145919
Almost clean backport except for /jdk/test/ProblemList.txt

The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test.

Change has been verified locally, test-fix only, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8205653 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8205653: test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and RmiSslBootstrapTest.sh fail with handshake_failure (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/625/head:pull/625
$ git checkout pull/625

Update a local copy of the PR:
$ git checkout pull/625
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/625/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 625

View PR using the GUI difftool:
$ git pr show -t 625

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/625.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 23, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 23, 2025

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8205653: test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and RmiSslBootstrapTest.sh fail with handshake_failure

Test failure due to unsupported DSA keys

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 136331b7f064d6d61abf3c09ba7106dc9a22a531 8205653: test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and RmiSslBootstrapTest.sh fail with handshake_failure Feb 23, 2025
@openjdk
Copy link

openjdk bot commented Feb 23, 2025

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base approval Requires approval; will be removed when approval is received rfr Pull request is ready for review labels Feb 23, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 23, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 23, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

keep it open

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 20, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Hi, can anyone take look this PR.

@sendaoYan
Copy link
Member Author

Thanks for the reviews @phohensee

@sendaoYan
Copy link
Member Author

GHA report several failures:

  1. Test gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java run timed out, this backport PR will not affect this test in theory, I think this timed out failure is unrelated to this PR.
  2. Test com/sun/jdi/PrivateTransportTest.sh run fails, this backport PR will not affect this test in theory, I think this timed out failure is unrelated to this PR.
  3. Test compiler/unsafe/OpaqueAccesses.java fails, which has been recorded by JDK-8337185, it's unrelated to this PR.
  4. Other failures are all CA expired issue, it's unrelated to this PR.

@sendaoYan
Copy link
Member Author

/approval request Backport from jdk11u-dev to jdk8u-dev to fix the test bug which cause test intermittent fails. Change has been verified locally, test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Apr 22, 2025

@sendaoYan
8205653: The approval request has been created successfully.

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label May 13, 2025
@openjdk openjdk bot removed rfr Pull request is ready for review approval Requires approval; will be removed when approval is received labels May 13, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented May 20, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@phohensee
Copy link
Member

The bot hasn't removed the oca label, even though @sendaoYan was approved quite some time ago.

@phohensee
Copy link
Member

Needs approval request.

@sendaoYan
Copy link
Member Author

/touch

@openjdk
Copy link

openjdk bot commented May 22, 2025

@sendaoYan The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Jun 4, 2025
@openjdk
Copy link

openjdk bot commented Jun 4, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 4, 2025
@sendaoYan
Copy link
Member Author

/approval request Backport from jdk11u-dev to jdk8u-dev to fix the test bug which cause test intermittent fails. Change has been verified locally, test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Jun 5, 2025

@sendaoYan
8205653: The approval request was already up to date.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jun 5, 2025
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 24, 2025
@sendaoYan
Copy link
Member Author

Thanks for the review and approved @phohensee @jerboaa

@sendaoYan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 24, 2025
@openjdk
Copy link

openjdk bot commented Jun 24, 2025

@sendaoYan
Your change (at version 53d7df3) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 24, 2025

Going to push as commit fd62363.
Since your change was applied there have been 54 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 24, 2025
@openjdk openjdk bot closed this Jun 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 24, 2025
@openjdk
Copy link

openjdk bot commented Jun 24, 2025

@phohensee @sendaoYan Pushed as commit fd62363.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants