Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283350: (tz) Update Timezone Data to 2022a #63

Closed

Conversation

dimitryc
Copy link
Contributor

@dimitryc dimitryc commented May 23, 2022

Please review the update to tzdata2022a

  • updated manually from the rearguard version (tzdata2022a-rearguard.tar.gz generated by cd tzdb-2022a && make rearguard_tarballs)
  • updated the copy of the timezone data in the test folder

Testing: tests for sun.util.calendar and java.time.test passed


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/63/head:pull/63
$ git checkout pull/63

Update a local copy of the PR:
$ git checkout pull/63
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/63/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 63

View PR using the GUI difftool:
$ git pr show -t 63

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/63.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2022

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 23, 2022
@mlbridge
Copy link

mlbridge bot commented May 23, 2022

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented May 24, 2022

@dimitryc Please change the PR title to Backport b05d4ccf8e54635c16bc2c26aa7a8fcc2e3b3dde as it's a backport of that update (I see the issue is not open warning).

@dimitryc dimitryc changed the title 8283350: (tz) Update Timezone Data to 2022a Backport b05d4ccf8e54635c16bc2c26aa7a8fcc2e3b3dde May 24, 2022
@openjdk openjdk bot changed the title Backport b05d4ccf8e54635c16bc2c26aa7a8fcc2e3b3dde 8283350: (tz) Update Timezone Data to 2022a May 24, 2022
@openjdk
Copy link

openjdk bot commented May 24, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 24, 2022
@dimitryc
Copy link
Contributor Author

@jerboaa thanks, done

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented May 24, 2022

@dimitryc This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8283350: (tz) Update Timezone Data to 2022a

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 7961755: 8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head
  • eb5711b: 8284620: CodeBuffer may leak _overflow_arena
  • db52470: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 24, 2022
@dimitryc
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 24, 2022

Going to push as commit 83fbc96.
Since your change was applied there have been 4 commits pushed to the master branch:

  • c5f96be: 8286989: Build failure on macOS after 8281814
  • 7961755: 8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head
  • eb5711b: 8284620: CodeBuffer may leak _overflow_arena
  • db52470: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 24, 2022
@openjdk openjdk bot closed this May 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 24, 2022
@openjdk
Copy link

openjdk bot commented May 24, 2022

@dimitryc Pushed as commit 83fbc96.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants