8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java #637

kurashige23 · 2025-03-13T01:13:55Z

Hi all,

This is a backport of JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java

Original patch doesn't apply cleanly to 8u because JDK-8056911 isn't backported to 8u.

Backporting JDK-8056911 involves changing the behavior of a public method so it is risky. In addition to that, it does not lead to significant bug fix. For these reasons, I do not think it is appropriate to apply JDK-8056911 as a dependent fix.
So I made a slightly different fix from the original patch. Specifically, I modified to use an ExtendedRobot instead of Robot.

Testing: java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java on RHEL9.4

Thanks.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
JDK-8160767 needs maintainer approval
Commit message must refer to an issue

Issue

JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java (Bug - P4 - Approved)

Reviewers

Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/637/head:pull/637
$ git checkout pull/637

Update a local copy of the PR:
$ git checkout pull/637
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/637/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 637

View PR using the GUI difftool:
$ git pr show -t 637

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/637.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-03-13T01:14:09Z

👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-03-13T01:14:25Z

@kurashige23 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

7fea411: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly"
41e6bf7: 8366112: [8u] GHA: Fix broken installation of Windows SDK
cc30193: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2025-03-13T01:14:40Z

This backport pull request has now been updated with issue from the original commit.

mlbridge · 2025-03-13T01:17:49Z

Webrevs

kurashige23 · 2025-03-13T01:26:24Z

This is a clean backport as only path changes.

/clean

openjdk · 2025-03-13T01:26:57Z

@kurashige23 The /clean pull request command is not enabled for this repository

mrserb · 2025-03-13T01:56:30Z

jdk/test/java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java

-        Util.waitForIdle(null);
+    private static void checkState(Frame frame, int state) {
+        frame.setExtendedState(state);
+        robot.waitForIdle();


I'm not sure this will be enough for jdk8. https://bugs.openjdk.org/browse/JDK-8056911 was not ported to jdk8, so Robot.waitForIdle() uses a "dummy" implementation.

Sorry, I wasn't aware that Robot.waitForIdle() uses a dummy implementation.
I thought it was necessary to apply JDK-8056911 first, but backporting JDK-8056911 has been rejected in the past because changing the behavior of public methods is undesirable.
I will consider whether I should backport JDK-8056911. If the JDK-8056911 backport is not appropriate, I will implement another fix in this PR.

I think that backporting JDK-8056911 is not consistent with consequences described in section "What form should back-ported patches take?" at Best practices for OpenJDK 8 updates . This is because backporting JDK-8056911 does not result in any significant bug fixes.
Therefore, I modified the test to use ExtendedRobot instead of Robot.

@mrserb

I'm sorry to bother you, I would like you to check my comment. Thanks.

@mrserb

I'm sorry to bother you, If you have time, I would like you to check my comment.
Thanks.

@mrserb

Just a quick follow-up on this PR when you have a moment. Thanks.

bridgekeeper · 2025-04-22T12:50:36Z

@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper · 2025-05-21T04:22:29Z

@kurashige23 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

kurashige23 · 2025-05-21T05:34:26Z

/open

openjdk · 2025-05-21T05:34:58Z

@kurashige23 This pull request is now open

kurashige23 · 2025-07-08T12:54:27Z

Could anyone review this PR?

bridgekeeper · 2025-08-19T03:28:03Z

@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

kurashige23 · 2025-08-20T10:08:17Z

Hi, @phohensee

Sorry for sudden mention.
I have dealt with this comment, but I haven't been able to get response for about 5 months.
If possible, could you review this PR instead? Thanks.

I think GHA error is not related to this PR fix.

phohensee

Done.

openjdk · 2025-08-20T18:46:09Z

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

kurashige23 · 2025-08-21T08:03:03Z

Thank you for your review.

/approval request Backporting this patch resolves failure of MaximizedToIconified.java.
Test-only fix, low risk.
Original patch does not apply cleanly because JDK-8056911 is not ported to jdk8. Backporting JDK-8056911 was rejected in the past because changing the behavior of public methods is undesirable. So I modified the test to use ExtendedRobot directly instead of applying JDK-8056911.
MaximizedToIconified.java passes on RHEL9.4.

openjdk · 2025-08-21T08:03:44Z

@kurashige23
8160767: The approval request has been created successfully.

kurashige23 · 2025-08-27T23:55:34Z

/integrate

openjdk · 2025-08-27T23:56:27Z

@kurashige23
Your change (at version 4cf30b1) is now ready to be sponsored by a Committer.

phohensee · 2025-08-28T17:57:36Z

/sponsor

openjdk · 2025-08-28T17:58:31Z

Going to push as commit bb19ce3.
Since your change was applied there have been 5 commits pushed to the master branch:

1d7e101: 8041924: [TESTBUG] sun/net/www/http/ChunkedOutputStream/checkError.java fails on some systems
f362183: 8056283: @ignore tools/javac/defaultMethods/Assertions.java until JDK-8047675 is fixed
7fea411: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly"
... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/2821dcef9484b0a551d1c6b4ab014892ab07b55a...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-08-28T17:58:39Z

@phohensee @kurashige23 Pushed as commit bb19ce3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

kurashige23 and others added 2 commits March 10, 2025 16:01

Backport b46b19cb58d8b43e57cd81a0588d4e18ad6afa9a

35b20d8

Merge branch 'openjdk:master' into fix_MaximizedToIconified

f5c7276

openjdk bot changed the title ~~Backport b46b19cb58d8b43e57cd81a0588d4e18ad6afa9a~~ 8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java Mar 13, 2025

openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Mar 13, 2025

mrserb reviewed Mar 13, 2025

View reviewed changes

kurashige23 and others added 2 commits March 24, 2025 17:28

Merge branch 'openjdk:master' into fix_MaximizedToIconified

83f55b5

Fix to use ExtendedRobot

34784ce

bridgekeeper bot closed this May 21, 2025

openjdk bot reopened this May 21, 2025

Merge branch 'openjdk:master' into fix_MaximizedToIconified

4cf30b1

phohensee approved these changes Aug 20, 2025

View reviewed changes

openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated labels Aug 21, 2025

openjdk bot removed the approval Requires approval; will be removed when approval is received label Aug 27, 2025

openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 27, 2025

openjdk bot added the integrated Pull request has been integrated label Aug 28, 2025

openjdk bot closed this Aug 28, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 28, 2025

8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java #637

8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java #637

Uh oh!

Conversation

kurashige23 commented Mar 13, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Mar 13, 2025

Uh oh!

openjdk bot commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Mar 13, 2025

Uh oh!

mlbridge bot commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

kurashige23 commented Mar 13, 2025

Uh oh!

openjdk bot commented Mar 13, 2025

Uh oh!

mrserb Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

kurashige23 Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

kurashige23 Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

kurashige23 May 21, 2025

Choose a reason for hiding this comment

Uh oh!

kurashige23 Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

kurashige23 Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

bridgekeeper bot commented Apr 22, 2025

Uh oh!

bridgekeeper bot commented May 21, 2025

Uh oh!

kurashige23 commented May 21, 2025

Uh oh!

openjdk bot commented May 21, 2025

Uh oh!

kurashige23 commented Jul 8, 2025

Uh oh!

bridgekeeper bot commented Aug 19, 2025

Uh oh!

kurashige23 commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phohensee left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Aug 20, 2025

Uh oh!

kurashige23 commented Aug 21, 2025

Uh oh!

openjdk bot commented Aug 21, 2025

Uh oh!

kurashige23 commented Aug 27, 2025

Uh oh!

openjdk bot commented Aug 27, 2025

Uh oh!

phohensee commented Aug 28, 2025

Uh oh!

openjdk bot commented Aug 28, 2025

Uh oh!

openjdk bot commented Aug 28, 2025

Uh oh!

Reviewers

Assignees

kurashige23 commented Mar 13, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Mar 13, 2025 •

edited

Loading

mlbridge bot commented Mar 13, 2025 •

edited

Loading

kurashige23 commented Aug 20, 2025 •

edited

Loading