-
Notifications
You must be signed in to change notification settings - Fork 159
8026976: ECParameters, Point does not match field size #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into |
@kurashige23 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @martinuy) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
I think the GHA error is a certificate issue and not related to this PR. /approval request Except for the fix in the Problemlist, original patch apply cleanly to 8u. The risk is low because the fix to the source is only for P11ECKeyFactory.java and it is just addition of switching by UseEcX963Encoding. pkcs11 tests on RHEL9 and GHA tests pass. |
@kurashige23 |
@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
I recognize that JDK-8026976 requires a maintainer approval. Thanks. |
@franferrax @martinuy Could somebody of you please review this, too? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for contributing this backport.
Thank you for your review. /integrate |
@kurashige23 |
/sponsor |
Going to push as commit 5e59411. |
@jerboaa @kurashige23 Pushed as commit 5e59411. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This is a backport of JDK-8026976: ECParameters, Point does not match field size
Except for the fix in the Problemlist and the one for Copyright year, original patch apply cleanly to 8u.
Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing
Thanks.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/643/head:pull/643
$ git checkout pull/643
Update a local copy of the PR:
$ git checkout pull/643
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/643/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 643
View PR using the GUI difftool:
$ git pr show -t 643
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/643.diff
Using Webrev
Link to Webrev Comment