Skip to content

8026976: ECParameters, Point does not match field size #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

kurashige23
Copy link
Contributor

@kurashige23 kurashige23 commented Mar 31, 2025

Hi all,

This is a backport of JDK-8026976: ECParameters, Point does not match field size

Except for the fix in the Problemlist and the one for Copyright year, original patch apply cleanly to 8u.

Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing

Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8026976 needs maintainer approval

Issue

  • JDK-8026976: ECParameters, Point does not match field size (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/643/head:pull/643
$ git checkout pull/643

Update a local copy of the PR:
$ git checkout pull/643
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/643/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 643

View PR using the GUI difftool:
$ git pr show -t 643

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/643.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 31, 2025

👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

@kurashige23 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8026976: ECParameters, Point does not match field size

Reviewed-by: phh, mbalao

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @martinuy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 55f5542ca2104df91e14693534cc7b3c36e81953 8026976: ECParameters, Point does not match field size Mar 31, 2025
@openjdk
Copy link

openjdk bot commented Mar 31, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 31, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 31, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@kurashige23
Copy link
Contributor Author

I think the GHA error is a certificate issue and not related to this PR.

/approval request Except for the fix in the Problemlist, original patch apply cleanly to 8u. The risk is low because the fix to the source is only for P11ECKeyFactory.java and it is just addition of switching by UseEcX963Encoding. pkcs11 tests on RHEL9 and GHA tests pass.

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

@kurashige23
8026976: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 1, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 29, 2025

@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@kurashige23
Copy link
Contributor Author

@jerboaa

I recognize that JDK-8026976 requires a maintainer approval.
You have given me a maintainer approval in openjdk/jdk11u-dev#2958.
I'm sorry to bother you, but could you approve JDK-8026976?

Thanks.

@jerboaa
Copy link
Contributor

jerboaa commented May 7, 2025

@franferrax @martinuy Could somebody of you please review this, too? Thanks!

Copy link
Contributor

@martinuy martinuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for contributing this backport.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 8, 2025
@kurashige23
Copy link
Contributor Author

Thank you for your review.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 8, 2025
@openjdk
Copy link

openjdk bot commented May 8, 2025

@kurashige23
Your change (at version d367074) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented May 8, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented May 8, 2025

Going to push as commit 5e59411.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 8, 2025
@openjdk openjdk bot closed this May 8, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label May 8, 2025
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 8, 2025
@openjdk
Copy link

openjdk bot commented May 8, 2025

@jerboaa @kurashige23 Pushed as commit 5e59411.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants