Skip to content

8352716: (tz) Update Timezone Data to 2025b #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

satyenme
Copy link

@satyenme satyenme commented Mar 31, 2025

Backport of tzdata2025b. Nearly clean, but contains zone.tab file, which was removed by JDK-8166983.

Reverted change to aliases.txt and displaynames.txt when running make in jdk/test/java/util/TimeZone/tools/share to avoid the jdk/test/java/util/TimeZone/Bug6329116.java test failing, just as was done previously for 2024b.

Passed tier1 tests, as well as jdk/test/java/util/TimeZone, jdk/test/java/time, jdk/test/sun/util/resources, jdk/test/sun/text/resources, and jdk/test/sun/util/calendar tests locally. Passing GHA sanity tests (other than known failures).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8352716 needs maintainer approval

Issue

  • JDK-8352716: (tz) Update Timezone Data to 2025b (Enhancement - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/644/head:pull/644
$ git checkout pull/644

Update a local copy of the PR:
$ git checkout pull/644
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/644/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 644

View PR using the GUI difftool:
$ git pr show -t 644

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/644.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 31, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

@satyenme This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8352716: (tz) Update Timezone Data to 2025b

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 1d205f5f0704f251eb68165f3caf1e70d542ae63 8352716: (tz) Update Timezone Data to 2025b Mar 31, 2025
@openjdk
Copy link

openjdk bot commented Mar 31, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 31, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 31, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@satyenme
Copy link
Author

satyenme commented Apr 1, 2025

/approval request for backport of 2025b tzdata. Nearly clean, but needed to re-add zone.tab file, which was removed by JDK-8166983.

Risk: Medium to Low. Tier 1 and relevant tz tests passing, as well as GHA sanity check tests. Backporting tzdata changes is a common enough procedure that, after review, we can be reasonably confident will work as intended.

Testing:

  • GHA Sanity Checks (with a couple known, unrelated failures)
  • Tier 1 tests locally
  • jdk/test/java/util/TimeZone, jdk/test/java/time, jdk/test/sun/util/resources, jdk/test/sun/text/resources, and jdk/test/sun/util/calendar tests locally

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

@satyenme
8352716: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 1, 2025
@satyenme
Copy link
Author

Update: this change has been integrated into Oracle JDK 8u461

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 16, 2025
@satyenme
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 19, 2025
@openjdk
Copy link

openjdk bot commented May 19, 2025

@satyenme
Your change (at version b7c33d5) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 20, 2025

Going to push as commit 6fd5ba5.
Since your change was applied there have been 23 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 20, 2025
@openjdk openjdk bot closed this May 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 20, 2025
@openjdk
Copy link

openjdk bot commented May 20, 2025

@phohensee @satyenme Pushed as commit 6fd5ba5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants