-
Notifications
You must be signed in to change notification settings - Fork 171
8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back phh! A progress list of the required criteria for merging this PR into |
|
@phohensee This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
GHA failures are unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Thanks!
|
Thanks, Roman! |
|
/approval request Backport for parity with Oracle 11.0.28. Clean except for copyright date and file location, low risk: test only, modified test passes, eliminates warning. |
|
@phohensee |
|
@phohensee This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/integrate |
|
Going to push as commit 3e4321d.
Your commit was automatically rebased without conflicts. |
|
@phohensee Pushed as commit 3e4321d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport for parity with Oracle 8u461. Clean except for copyright date and file location, low risk: test only, modified test passes, eliminates warning.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/645/head:pull/645$ git checkout pull/645Update a local copy of the PR:
$ git checkout pull/645$ git pull https://git.openjdk.org/jdk8u-dev.git pull/645/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 645View PR using the GUI difftool:
$ git pr show -t 645Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/645.diff
Using Webrev
Link to Webrev Comment