8278472: Invalid value set to CANDIDATEFORM structure

[kurashige23]

Hi all,

This is a backport of JDK-8278472: Invalid value set to CANDIDATEFORM structure

Except for the fix for Copyright year and the path change, original patch applies cleanly to 8u.
This resolves an issue where the candidate window does not appear when using an IME other than Microsoft IME.

Testing: jdk_desktop tests on Windows Server 2022 (some tests failed, but they failed before this fix was made)

Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8278472 needs maintainer approval

Issue

• JDK-8278472: Invalid value set to CANDIDATEFORM structure (Bug - P3 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/648/head:pull/648
$ git checkout pull/648

Update a local copy of the PR:
$ git checkout pull/648
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/648/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 648

View PR using the GUI difftool:
$ git pr show -t 648

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/648.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kurashige23 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8278472: Invalid value set to CANDIDATEFORM structure

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 656b3cf: 8186143: keytool -ext option doesn't accept wildcards for DNS subject alternative names
• eca7a30: 8071996: split_if accesses NULL region of ConstraintCast
• 5e59411: 8026976: ECParameters, Point does not match field size

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (bdae29de)

[openjdk]

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[kurashige23]

I think the GHA error is a certificate issue and not related to this PR.

/approval request Small and trivial fix, low risk. Except for the fix for Copyright year and the path change, original patch applies cleanly. jdk_desktop tests on Windows Server 2022 passed (some tests failed, but they failed before this fix was made)

[openjdk]

@kurashige23
8278472: The approval request has been created successfully.

[kurashige23]

Thank you for your review.

/integrate

[openjdk]

@kurashige23
Your change (at version bdae29d) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 1304a9b.
Since your change was applied there have been 4 commits pushed to the master branch:

• 176d674: 8296631: NSS tests failing on OL9 linux-aarch64 hosts
• 656b3cf: 8186143: keytool -ext option doesn't accept wildcards for DNS subject alternative names
• eca7a30: 8071996: split_if accesses NULL region of ConstraintCast
• ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/55273f7267b95cf38743bb32ea61a513fbafb06e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @kurashige23 Pushed as commit 1304a9b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.