Skip to content

Conversation

@vieiro
Copy link
Contributor

@vieiro vieiro commented May 9, 2025

Backport of JDK-8303770 from 11. Mostly clean (certfile location differs from 11).

Test jdk/test/sun/security/lib/cacerts/VerifyCACerts.java passes on RHEL8, x86_64, gcc8.5.0.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8303770 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303770: Remove Baltimore root certificate expiring in May 2025 (Task - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/650/head:pull/650
$ git checkout pull/650

Update a local copy of the PR:
$ git checkout pull/650
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/650/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 650

View PR using the GUI difftool:
$ git pr show -t 650

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/650.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2025

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 9, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport c0e7aa6c122e88e0d749ac3e8edf2cda9c5f53da 8303770: Remove Baltimore root certificate expiring in May 2025 May 9, 2025
@openjdk
Copy link

openjdk bot commented May 9, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 9, 2025
@mlbridge
Copy link

mlbridge bot commented May 9, 2025

Webrevs

@vieiro
Copy link
Contributor Author

vieiro commented May 12, 2025

Note that some other jdk/security_infra tests have been failing for a while, but are unrelated to the change.

@vieiro vieiro marked this pull request as draft May 12, 2025 14:07
@openjdk openjdk bot removed the rfr Pull request is ready for review label May 12, 2025
@vieiro vieiro force-pushed the backports/JDK-8303770 branch from 35aec74 to c78e6ee Compare May 12, 2025 14:10
@vieiro vieiro marked this pull request as ready for review May 12, 2025 15:02
@openjdk openjdk bot added the rfr Pull request is ready for review label May 12, 2025
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented May 14, 2025

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@vieiro
Copy link
Contributor Author

vieiro commented Jun 2, 2025

/approval request please Approve this PR that removes a CA certificate that is expiring in May, it would be great if we could get this merged for the 2025-07 release.

@openjdk
Copy link

openjdk bot commented Jun 2, 2025

@vieiro
8303770: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jun 2, 2025
@vieiro
Copy link
Contributor Author

vieiro commented Jun 3, 2025

This one moved to openjdk/jdk8u#72

@vieiro vieiro closed this Jun 3, 2025
@sendaoYan
Copy link
Member

This backport seems backport to jdk8u, but I think jdk8u-dev also need to backported?

@jerboaa
Copy link
Contributor

jerboaa commented Jul 10, 2025

This backport seems backport to jdk8u, but I think jdk8u-dev also need to backported?

This will get there in time when a merge from jdk8u to jdk8u-dev happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants