-
Notifications
You must be signed in to change notification settings - Fork 171
8350498: Remove two Camerfirma root CA certificates #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
| * @library /lib/security | ||
| * Camerfirma root are invalid | ||
| * @library /test/lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The roots => root change is fine. The test library change not. 8u has lib/security not /test/lib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, uploaded the changes in the recent commit. Sorry by that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is missing the bug line update that the JDK 11u patch has here:
openjdk/jdk11u-dev@8894d6a#diff-ecedb2ba9c75491cd95fc614c6580b565d2d61a10a253f6a2fcd0fd774b535c3R31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing! Uploaded in the recent commit.
|
Uploaded missing changes and retested. Tests pass. |
|
/approval request Please approve this backport that removes two no-longer active CA certificates. Tests pass. Low risk. |
|
@vieiro Please move this PR to https://github.com/openjdk/jdk8u (close this one and open a new one there; sorry for the inconvenience) since jdk8u-dev is closed for now and we'd like this to go into the July release. |
|
The parent pull request that this pull request depends on has been closed without being integrated and the target branch of this pull request has been updated as the previous branch was deleted. This means that changes from the parent pull request will start to show up in this pull request. If closing the parent pull request was done in error, it will need to be re-opened and this pull request will need to manually be retargeted again. |
|
@jerboaa No worries. Closing this one in favor of openjdk/jdk8u#73 in 8u. Thanks! |
Backport of JDK-8350498 from 11 that removes two non root CA certificates no longer active.
The PR is on top of #650 (for JDK-8303770) to avoid conflicts, since
CHECKSUMinVerifyCACerts.javais modified by both issues.Not clean, as file locations have changed between 8 and 11.
Test
VerifyCACerts.javapasses:Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/651/head:pull/651$ git checkout pull/651Update a local copy of the PR:
$ git checkout pull/651$ git pull https://git.openjdk.org/jdk8u-dev.git pull/651/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 651View PR using the GUI difftool:
$ git pr show -t 651Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/651.diff
Using Webrev
Link to Webrev Comment