-
Notifications
You must be signed in to change notification settings - Fork 164
8274597: Some of the dnd tests time out and fail intermittently #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into |
@kurashige23 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issues from the original commit. |
Webrevs
|
Thank you for your review. GHA error is a certificate issue and not related to this PR. /approval request No risk, only a test change. |
@kurashige23 |
/approve yes |
@jerboaa |
@jerboaa, somehow your approval didn't "take". |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8274597
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
I dealt with #653 (comment), so could you approve again? Thanks. |
/integrate |
@kurashige23 |
/sponsor |
Going to push as commit abda9d8. |
@phohensee @kurashige23 Pushed as commit abda9d8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
This is a backport of JDK-8274597: Some of the dnd tests time out and fail intermittently
Original patch applies cleanly except for path changes. This PR depends on #652 . So #652 shoud be integrated first.
Testing: AcceptDropMultipleTimes.java, MissedDragExitTest.java, ExtraDragEnterTest.java and MissingDragExitEventTest.java pass on Windows11
Thanks.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/653/head:pull/653
$ git checkout pull/653
Update a local copy of the PR:
$ git checkout pull/653
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/653/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 653
View PR using the GUI difftool:
$ git pr show -t 653
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/653.diff
Using Webrev
Link to Webrev Comment