Skip to content

8274597: Some of the dnd tests time out and fail intermittently #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

kurashige23
Copy link
Member

@kurashige23 kurashige23 commented May 14, 2025

Hi,

This is a backport of JDK-8274597: Some of the dnd tests time out and fail intermittently

Original patch applies cleanly except for path changes. This PR depends on #652 . So #652 shoud be integrated first.

Testing: AcceptDropMultipleTimes.java, MissedDragExitTest.java, ExtraDragEnterTest.java and MissingDragExitEventTest.java pass on Windows11

Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8028998 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8274597 needs maintainer approval

Issues

  • JDK-8274597: Some of the dnd tests time out and fail intermittently (Bug - P3 - Approved)
  • JDK-8028998: [TEST_BUG] [macosx] java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java failed (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/653/head:pull/653
$ git checkout pull/653

Update a local copy of the PR:
$ git checkout pull/653
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/653/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 653

View PR using the GUI difftool:
$ git pr show -t 653

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/653.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 14, 2025

👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into pr/652 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 14, 2025

@kurashige23 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274597: Some of the dnd tests time out and fail intermittently
8028998: [TEST_BUG] [macosx] java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java failed

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 669ac611b269bbda5c53d84173e5c9d0eb4ce919 8274597: Some of the dnd tests time out and fail intermittently May 14, 2025
@openjdk
Copy link

openjdk bot commented May 14, 2025

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 14, 2025
@mlbridge
Copy link

mlbridge bot commented May 14, 2025

Webrevs

@kurashige23
Copy link
Member Author

kurashige23 commented May 15, 2025

Thank you for your review.

GHA error is a certificate issue and not related to this PR.

/approval request No risk, only a test change.
Clean backport except for path changes.
Testing: AcceptDropMultipleTimes.java, MissedDragExitTest.java, ExtraDragEnterTest.java and MissingDragExitEventTest.java pass on Windows11

@openjdk
Copy link

openjdk bot commented May 15, 2025

@kurashige23
8274597: The approval request has been created successfully.
8028998: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels May 15, 2025
@jerboaa
Copy link
Contributor

jerboaa commented May 16, 2025

/approve yes

@openjdk
Copy link

openjdk bot commented May 16, 2025

@jerboaa
8274597: The approval request has been approved.
8028998: The approval request has been approved.

@phohensee
Copy link
Member

@jerboaa, somehow your approval didn't "take".

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/652 to master May 21, 2025 16:10
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8274597
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 21, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label May 22, 2025
@kurashige23
Copy link
Member Author

@phohensee

I dealt with #653 (comment), so could you approve again?

Thanks.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 22, 2025
@kurashige23
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 22, 2025
@openjdk
Copy link

openjdk bot commented May 22, 2025

@kurashige23
Your change (at version 352fcb3) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 22, 2025

Going to push as commit abda9d8.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 22, 2025
@openjdk openjdk bot closed this May 22, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 22, 2025
@openjdk
Copy link

openjdk bot commented May 22, 2025

@phohensee @kurashige23 Pushed as commit abda9d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants