8296631: NSS tests failing on OL9 linux-aarch64 hosts

[kurashige23]

Hi,

This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts

Original patch does not apply cleanly for the following reasons:

・Fix to test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied because it is a fix to code that does not exist in jdk8.
・Fix to test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh can not be applied since test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh added in https://bugs.openjdk.org/browse/JDK-8240256 (jdk17).
・Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in https://bugs.openjdk.org/browse/JDK-8220753 (jdk13).
・pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed by https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass.

Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing

Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8296631 needs maintainer approval

Issue

• JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts (Bug - P3 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/654/head:pull/654
$ git checkout pull/654

Update a local copy of the PR:
$ git checkout pull/654
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/654/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 654

View PR using the GUI difftool:
$ git pr show -t 654

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/654.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kurashige23 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8296631: NSS tests failing on OL9 linux-aarch64 hosts

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 656b3cf: 8186143: keytool -ext option doesn't accept wildcards for DNS subject alternative names

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (c5c1763b)

[openjdk]

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[kurashige23]

Thank you for your review.

GHA error is a certificate issue and not related to this PR.

/approval request Backporting this patch resolves NSS tests failure.
Original patch does not apply cleanly because some code does not exist in jdk8.
Test-only fix, low risk.
Pkcs11 tests on RHEL9 and GHA pass.

[openjdk]

@kurashige23
8296631: The approval request has been created successfully.

[kurashige23]

Thank you for your review.

/integrate

[openjdk]

@kurashige23
Your change (at version c5c1763) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 176d674.
Since your change was applied there has been 1 commit pushed to the master branch:

• 656b3cf: 8186143: keytool -ext option doesn't accept wildcards for DNS subject alternative names

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @kurashige23 Pushed as commit 176d674.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[kurashige23]

@jerboaa @phohensee

This PR was integrated, but JBS issue for backport was not issued.
So there is no line for openjdk8u at "Backports" part on JDK-8296631 .

I don't remember doing anything different from the normal process.
Do you know the cause?

Thanks.

[phohensee]

I have no idea why. @jerboaa?

[gnu-andrew]

@jerboaa @phohensee

This PR was integrated, but JBS issue for backport was not issued. So there is no line for openjdk8u at "Backports" part on JDK-8296631 .

I don't remember doing anything different from the normal process. Do you know the cause?

Thanks.

I just spotted this as well, as it's still showing up in the "Approved without Push" filter. Looking into it.

[gnu-andrew]

I've e-mailed ops and CCed you, @phohensee. I'm afraid I couldn't see an e-mail on your account, @kurashige23, to add you in as well but will let you know what happens.

[gnu-andrew]

Fixed now. The ticket was there but not visible.

[phohensee]

Thank you, Andrew.

[kurashige23]

Thank you.