8185348: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions

[zhengyu123]

Please review this patch for the parity of Oracle's JDK-8185348.

Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation.

Before patch, slowjvmti test case from JDK-8185348:
16366ms

After patch:
3ms

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8185348 needs maintainer approval

Issue

• JDK-8185348: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions (Bug - P3 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/656/head:pull/656
$ git checkout pull/656

Update a local copy of the PR:
$ git checkout pull/656
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/656/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 656

View PR using the GUI difftool:
$ git pr show -t 656

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/656.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8185348: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (44c3342a)
• 00: Full (d6115500)

[phohensee]

Lgtm.

[openjdk]

⚠️ @zhengyu123 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[jerboaa]

@zhengyu123 The master bug for this is JDK-8185348. We should track it as a backport. In this case there is no sha to reference in the PR title. Please use Backport JDK-8185348 which should work in this case and get the backport label added.

[jerboaa]

@zhengyu123 #656 (comment) needs to be addressed before this can be approved.

[bridgekeeper]

@zhengyu123 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[zhengyu123]

@jerboaa Sorry for replying late. I would like to clarify that there is not public patch for JDK-8185348, so that it is not possible to have direct back port.

[jerboaa]

@jerboaa Sorry for replying late. I would like to clarify that there is not public patch for JDK-8185348, so that it is not possible to have direct back port.

Yes, I believe for that reason there is the Backport JDK-8185348 trick or Backport 8185348 as PR title as alluded to in this comment to massage the bots to recognize it as backport. Please try that. See https://bugs.openjdk.org/browse/SKARA-1076

[zhengyu123]

/Backport JDK-8185348

[zhengyu123]

Backport 8185348

[openjdk]

This backport pull request has now been updated with the original issue, but not the original commit. If you have the original commit hash, please update the pull request title with Backport <hash>.

[zhengyu123]

@jerboaa Sorry for replying late. I would like to clarify that there is not public patch for JDK-8185348, so that it is not possible to have direct back port.

Yes, I believe for that reason there is the Backport JDK-8185348 trick or Backport 8185348 as PR title as alluded to in this comment to massage the bots to recognize it as backport. Please try that. See https://bugs.openjdk.org/browse/SKARA-1076

Ah, forgot about it, it has been a while. Thanks!

[jerboaa]

I suggest to merge latest master before integrating since it's been a long time since CI ran.

[zhengyu123]

/integrate

[openjdk]

Going to push as commit 8234312.

[openjdk]

@zhengyu123 Pushed as commit 8234312.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.