Skip to content

Conversation

@kvergizova
Copy link
Contributor

@kvergizova kvergizova commented May 30, 2025

I'd like to backport JDK-8356096 for parity with Oracle 8u461.

Backport is not clean due to minor context differences in the test ValidateISO4217.java and in ISO4217-list-one.txt, changes were applied manually.
Changes in CurrencyData.properties and CurrencyNames.properties applied cleanly after paths reshuffling.

jdk/test/java/util/Currency tests passed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8356096 needs maintainer approval

Issue

  • JDK-8356096: ISO 4217 Amendment 179 Update (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/657/head:pull/657
$ git checkout pull/657

Update a local copy of the PR:
$ git checkout pull/657
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/657/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 657

View PR using the GUI difftool:
$ git pr show -t 657

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/657.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2025

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 30, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b8484be137a9d8bf6463188e1fc68b22db0b52c3 8356096: ISO 4217 Amendment 179 Update May 30, 2025
@openjdk
Copy link

openjdk bot commented May 30, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 30, 2025
@mlbridge
Copy link

mlbridge bot commented May 30, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented May 30, 2025

⚠️ @kvergizova This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@kvergizova
Copy link
Contributor Author

/approval request I'd like to backport it for parity with Oracle 8u461.
11u patch doesn't apply cleanly, changes in tests applied manually.
Currency tests pass.

@openjdk
Copy link

openjdk bot commented May 30, 2025

@kvergizova
8356096: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label May 30, 2025
@jerboaa
Copy link
Contributor

jerboaa commented Jun 2, 2025

Please move this one to openjdk/jdk8u since we entered rampdown and it would be good to have in the July release.

@jerboaa
Copy link
Contributor

jerboaa commented Jun 3, 2025

Please close this PR. Replaced by openjdk/jdk8u#74

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Jun 3, 2025
@kvergizova kvergizova closed this Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants