-
Notifications
You must be signed in to change notification settings - Fork 171
8356096: ISO 4217 Amendment 179 Update #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request I'd like to backport it for parity with Oracle 8u461. |
|
@kvergizova |
|
Please move this one to openjdk/jdk8u since we entered rampdown and it would be good to have in the July release. |
|
Please close this PR. Replaced by openjdk/jdk8u#74 |
I'd like to backport JDK-8356096 for parity with Oracle 8u461.
Backport is not clean due to minor context differences in the test ValidateISO4217.java and in ISO4217-list-one.txt, changes were applied manually.
Changes in CurrencyData.properties and CurrencyNames.properties applied cleanly after paths reshuffling.
jdk/test/java/util/Currency tests passed.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/657/head:pull/657$ git checkout pull/657Update a local copy of the PR:
$ git checkout pull/657$ git pull https://git.openjdk.org/jdk8u-dev.git pull/657/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 657View PR using the GUI difftool:
$ git pr show -t 657Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/657.diff
Using Webrev
Link to Webrev Comment