8049228: Improve multithreaded scalability of InetAddress cache

[lusou-zhangquan]

Backport JDK-8049228 to improve multithreaded scalability of InetAddress cache

Backport-of 250fbb065a789a303d692d698c9b69117bf6cd2c

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issues

• JDK-8049228: Improve multithreaded scalability of InetAddress cache
• JDK-7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime for more precise and accurate

Reviewers

• Paul Hohensee (@phohensee - Reviewer) ⚠️ Review applies to 08467055
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/70/head:pull/70
$ git checkout pull/70

Update a local copy of the PR:
$ git checkout pull/70
$ git pull https://git.openjdk.org/jdk8u-dev pull/70/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 70

View PR using the GUI difftool:
$ git pr show -t 70

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/70.diff

[bridgekeeper]

👋 Welcome back lusou-zhangquan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 04: Full - Incremental (a7aece3e)
• 03: Full - Incremental (68cb8d33)
• 02: Full (08467055)
• 01: Full - Incremental (5fbde719)
• 00: Full (799a4f39)

[jerboaa]

Please change the PR title to Backport 250fbb065a789a303d692d698c9b69117bf6cd2c and close the manual bug you've created for this backport. The original issue will be used instead once you use the said PR title: https://bugs.openjdk.org/browse/JDK-8049228

[openjdk]

This backport pull request has now been updated with issues from the original commit.

[lusou-zhangquan]

@jerboaa PR title has been changed as your advise, but I have no idea about how to close the manual bug JDK-8288718 I created. Could you please provide any suggestions?

[openjdk-notifier]

@lusou-zhangquan Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[jerboaa]

@jerboaa PR title has been changed as your advise, but I have no idea about how to close the manual bug JDK-8288718 I created. Could you please provide any suggestions?

I've closed it as a duplicate for you now.

[phohensee]

Looks fine, but please run at least tier1 tests.

[openjdk-notifier]

@lusou-zhangquan Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[lusou-zhangquan]

@jerboaa PR title has been changed as your advise, but I have no idea about how to close the manual bug JDK-8288718 I created. Could you please provide any suggestions?

I've closed it as a duplicate for you now.

Thanks a lot. Won't make similar mistakes next time.

[lusou-zhangquan]

Looks fine, but please run at least tier1 tests.

Re-run the gate and passed. Please take a look again.

[lusou-zhangquan]

@phohensee Please take a look at this PR again, thanks a lot.

[phohensee]

Lgtm.

[openjdk]

@lusou-zhangquan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8049228: Improve multithreaded scalability of InetAddress cache
7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime for more precise and accurate

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

• d0ad242: 8285497: Add system property for Java SE specification maintenance version
• e3251a2: 8232950: SUNPKCS11 Provider incorrectly check key length for PSS Signatures.
• 41c7d2d: 8039955: [TESTBUG] jdk/lambda/LambdaTranslationTest1 - java.lang.AssertionError: expected [d:1234.000000] but found [d:1234,000000]
• a4d4973: 8254318: Remove .hgtags
• 8ad9018: 8285400: Add '@APinote' to the APIs defined in Java SE 8 MR 3
• 3a5b2cd: 8201793: (ref) Reference object should not support cloning
• 1b52b01: 8183107: PKCS11 regression regarding checkKeySize
• e633df1: 8175797: (ref) Reference::enqueue method should clear the reference object before enqueuing
• 5323ef6: 8254178: Remove .hgignore
• 4cc462a: 8214427: probable bug in logic of ConcurrentHashMap.addCount()
• ... and 33 more: https://git.openjdk.org/jdk8u-dev/compare/83e90957bef15267bed792ee5d8d65899a2487e8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[lusou-zhangquan]

/integrate

[openjdk]

@lusou-zhangquan
Your change (at version 0846705) is now ready to be sponsored by a Committer.

[jerboaa]

@lusou-zhangquan Please only issue /integrate once you have jdk8u-fix-yes on the bug. See "Contributing" section in https://wiki.openjdk.org/display/jdk8u In particular steps 10 and 11.

[phohensee]

@ lusou-zhangquan, I strongly suspect the copyright date conflict in InetAddressCachePolicy.java would cause a merge failure if I sponsored this. Once you fix it I'll re-review and sponsor.

[lusou-zhangquan]

I've approved this one, but as I commented on the bug, it would be nice to know the reasoning for this backport. Approvals are primarily about risk assessment in the context of the whole JDK.

In this case, it's been in later JDKs for years, and is realistically borderline between being an enhancement and a bug fix (see https://bugs.openjdk.org/browse/JDK-8171346). I think it would be preferable to deal with any issues in the new code rather than the current outdated code, which is doing its own locking that is prone to error.

This bug is reproduced in our DNS service, which is running on jdk8 and hard to be upgraded to newer versions. So we hope to backport it and eliminate this potential risk for all jdk8 users.

[lusou-zhangquan]

@ lusou-zhangquan, I strongly suspect the copyright date conflict in InetAddressCachePolicy.java would cause a merge failure if I sponsored this. Once you fix it I'll re-review and sponsor.

Copyright date has been updated in latest commit, thanks for your suggestion.

[gnu-andrew]

Wait, what? Why are we changing the copyright dates? This is not part of the original patch. Please revert this change.

[gnu-andrew]

/reviewers 2 reviewer

[openjdk]

@gnu-andrew
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

[phohensee]

That was my bad. Somehow I thought the original patch updated the copyright date. Please revert to the previous version.

[gnu-andrew]

That was my bad. Somehow I thought the original patch updated the copyright date. Please revert to the previous version.

No worries. I just couldn't work out the issue you were referring to and indeed there is no 2022 bump in the original patch.

[gnu-andrew]

Ok, let's try again :)

[phohensee]

Just need an integrate comment. :)

[lusou-zhangquan]

/summary
8049228: Improve multithreaded scalability of InetAddress cache
7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime for more precise and accurate

Reviewed-by: phh, andrew

[openjdk]

@lusou-zhangquan Setting summary to:

8049228: Improve multithreaded scalability of InetAddress cache
7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime for more precise and accurate

Reviewed-by: phh, andrew

[lusou-zhangquan]

/summary

[lusou-zhangquan]

/summary 8049228: Improve multithreaded scalability of InetAddress cache 7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime for more precise and accurate

Reviewed-by: phh, andrew

I intended to update summary of this PR with this summary command before integrate, but it looks like not working as expected. And now jcheck failed with this error message:

Exception occurred during jcheck - the operation will be retried

Incorrectly formatted commit message: 8049228: Improve multithreaded scalability of InetAddress cache
7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime for more precise and accurate

8049228: Improve multithreaded scalability of InetAddress cache
7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime for more precise and accurate

Reviewed-by: phh, andrew

Reviewed-by: phh, Andrew

Is this my operation fault or jcheck bug? Could anybody help to solve this problem. Thanks a lot.

[jerboaa]

/summary 8049228: Improve multithreaded scalability of InetAddress cache 7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime for more precise and accurate
Reviewed-by: phh, andrew

I intended to update summary of this PR with this summary command before integrate, but it looks like not working as expected. And now jcheck failed with this error message:

Exception occurred during jcheck - the operation will be retried

Incorrectly formatted commit message: 8049228: Improve multithreaded scalability of InetAddress cache
7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime for more precise and accurate

8049228: Improve multithreaded scalability of InetAddress cache
7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime for more precise and accurate

Reviewed-by: phh, andrew

Reviewed-by: phh, Andrew

Is this my operation fault or jcheck bug? Could anybody help to solve this problem. Thanks a lot.

Don't set the commit message like that using /summary. What you want is /issue add. Reviewed-by fields are set by the bots based on the approving reviewers, so it's no surprise it didn't like that. That being said, for all intents an purposes what the bot suggested in #70 (comment) pretty much matches what you want, no? What is it that you want to achieve exactly?

[jerboaa]

/summary
Remove me

[jerboaa]

@lusou-zhangquan It looks like that has broken the bots. Best to file a SKARA issue here: https://bugs.openjdk.org/browse/SKARA if you can't create issues, I can help with that.

[gnu-andrew]

It's probably simpler to just open a fresh PR.

[lusou-zhangquan]

Close this PR and open a fresh one because of broken bots.

[openjdk]

@lusou-zhangquan Removing existing summary

[openjdk]

@jerboaa Only the author (@lusou-zhangquan) is allowed to issue the /summary command.