Skip to content

8219006: AArch64: Register corruption in slow subtype check#700

Closed
theRealAph wants to merge 1 commit intoopenjdk:masterfrom
theRealAph:JDK-8219006-backport
Closed

8219006: AArch64: Register corruption in slow subtype check#700
theRealAph wants to merge 1 commit intoopenjdk:masterfrom
theRealAph:JDK-8219006-backport

Conversation

@theRealAph
Copy link
Contributor

@theRealAph theRealAph commented Sep 19, 2025

The backport is clean except for changed pathnames.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8219006 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8219006: AArch64: Register corruption in slow subtype check (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/700/head:pull/700
$ git checkout pull/700

Update a local copy of the PR:
$ git checkout pull/700
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/700/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 700

View PR using the GUI difftool:
$ git pr show -t 700

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/700.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2025

👋 Welcome back aph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 19, 2025

@theRealAph This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8219006: AArch64: Register corruption in slow subtype check

Reviewed-by: phh, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 4ac927853957fe691692137a6cabbd1b141b95d4 8219006: AArch64: Register corruption in slow subtype check Sep 19, 2025
@openjdk
Copy link

openjdk bot commented Sep 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review approval Requires approval; will be removed when approval is received labels Sep 19, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 19, 2025

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backport looks good.

I see the original analysis figured this is a problem for debug builds. Have you seen in failing in release builds?

@theRealAph
Copy link
Contributor Author

I see the original analysis figured this is a problem for debug builds. Have you seen in failing in release builds?

No, and I guess that's why we didn't backport it at the time, but we're testing non-product builds.

@shipilev
Copy link
Member

I see the original analysis figured this is a problem for debug builds. Have you seen in failing in release builds?

No, and I guess that's why we didn't backport it at the time, but we're testing non-product builds.

OK!

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 22, 2025
@theRealAph
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 22, 2025

Going to push as commit 26a41cd.
Since your change was applied there have been 33 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 22, 2025
@openjdk openjdk bot closed this Sep 22, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2025
@openjdk
Copy link

openjdk bot commented Sep 22, 2025

@theRealAph Pushed as commit 26a41cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants