-
Notifications
You must be signed in to change notification settings - Fork 171
8348596: Update FreeType to 2.13.3 #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into |
|
@judovana This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
This backport pull request has now been updated with issue from the original commit. |
|
This backport pull request has now been updated with issue from the original commit. |
without:
--- jdk/make/lib/Awt2dLibraries.gmk
+++ jdk/make/lib/Awt2dLibraries.gmk
@@ -527,6 +527,7 @@ else
E_END_OF_LOOP_CODE_NOT_REACHED, \
DISABLED_WARNINGS_microsoft := 4018 4267 4244 4312 4819, \
DISABLED_WARNINGS_gcc := implicit-fallthrough cast-function-type bad-function-cast, \
+ DISABLED_WARNINGS_clang := missing-declarations, \
LDFLAGS := $(LDFLAGS_JDKLIB) \
$(call SET_SHARED_LIBRARY_ORIGIN), \
))
|
This backport pull request has now been updated with issue from the original commit. |
|
/issue add 8285686 8290334 8298974 8293672 8306881 8316028 8348596 |
|
@judovana Adding additional issue to issue list: Adding additional issue to issue list: Adding additional issue to issue list: Adding additional issue to issue list: Adding additional issue to issue list: |
|
/approval request It would be nice to have freetype aligned with other JDKs. It meansd to move jdk8 up to 2.13.3 before next release |
|
@judovana |
|
This backport pull request has now been updated with issue from the original commit. |
|
This backport pull request has now been updated with issue from the original commit. |
|
/issue add 8285686 8290334 8298974 8293672 8306881 8316028 8348596 |
|
@judovana Updating description of additional solved issue: Updating description of additional solved issue: Updating description of additional solved issue: Adding additional issue to issue list: Updating description of additional solved issue: |
|
Only |
|
|
||
| %% This notice is provided with respect to Freetype v2.9 which may be | ||
| included with JRE 8, JDK 8, and OpenJDK 8. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version in the title %% This notice is provided with respect to Freetype v2.9 should also be updated to v2.13.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanx! You have sharp eye. This was added in initial commit, and is not appearing in other JDKs (due to lack of THIR_PARTY_README). Will fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. The changes LGTM now.
Unfortunately, I'm not a reviewer, so I can't approve them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. The changes LGTM now. Unfortunately, I'm not a reviewer, so I can't approve them.
Thank you! I believe it is on Andrew's list for rampdownn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I'm going to look at it now. @kvergizova thanks for looking at this and catching that issue. Please feel free to at least do a GitHub review so you are credited in the commit message, even though it won't count as a 'Reviewer' to allow the change through.
This notice is now provided for v2.13.3
gnu-andrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good against the 11u commits. I missed that the version was referenced in THIRD_PARTY_README when reviewing the last PR so thanks to @kvergizova for catching that.
|
/approve yes |
|
@gnu-andrew |
|
/integrate |
|
/sponsor |
|
Going to push as commit de76f06. |
|
@gnu-andrew @judovana Pushed as commit de76f06. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This should be last PR on toppic of free type backport. At the end it should contain:
I will run full qa on 2.12.0 and 2.13.0 Buildability and tier1 tests on others.
The 2.13.3. will get full qa during rampdown I guess...
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/728/head:pull/728$ git checkout pull/728Update a local copy of the PR:
$ git checkout pull/728$ git pull https://git.openjdk.org/jdk8u-dev.git pull/728/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 728View PR using the GUI difftool:
$ git pr show -t 728Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/728.diff
Using Webrev
Link to Webrev Comment