Skip to content

Conversation

@judovana
Copy link
Contributor

@judovana judovana commented Nov 28, 2025

This should be last PR on toppic of free type backport. At the end it should contain:

  • 8285686: Update FreeType to 2.12.0 (pushed, testing in progress)
  • 8290334: Update FreeType to 2.12.1 (pushed, smoketests done)
  • 8298974: Add ftcolor.c to imported freetype sources (pushed, smoketests done)
  • 8293672: Update freetype md file (not clean)
  • 8306881: Update FreeType to 2.13.0 (pushed, testing scheduled)
  • 8316028: Update FreeType to 2.13.2 (pushed, smoketests done)
  • 8348596: Update FreeType to 2.13.3 (pushed, smoketests done)

I will run full qa on 2.12.0 and 2.13.0 Buildability and tier1 tests on others.
The 2.13.3. will get full qa during rampdown I guess...


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8285686 needs maintainer approval
  • JDK-8290334 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8293672 needs maintainer approval
  • JDK-8306881 needs maintainer approval
  • JDK-8348596 needs maintainer approval
  • JDK-8298974 needs maintainer approval
  • JDK-8316028 needs maintainer approval

Issues

  • JDK-8348596: Update FreeType to 2.13.3 (Bug - P3 - Approved)
  • JDK-8285686: Update FreeType to 2.12.0 (Bug - P3 - Approved)
  • JDK-8290334: Update FreeType to 2.12.1 (Bug - P3 - Approved)
  • JDK-8298974: Add ftcolor.c to imported freetype sources (Bug - P4 - Approved)
  • JDK-8293672: Update freetype md file (Bug - P3 - Approved)
  • JDK-8316028: Update FreeType to 2.13.2 (Bug - P3 - Approved)
  • JDK-8306881: Update FreeType to 2.13.0 (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/728/head:pull/728
$ git checkout pull/728

Update a local copy of the PR:
$ git checkout pull/728
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/728/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 728

View PR using the GUI difftool:
$ git pr show -t 728

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/728.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2025

👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 28, 2025

@judovana This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8348596: Update FreeType to 2.13.3
8285686: Update FreeType to 2.12.0
8290334: Update FreeType to 2.12.1
8298974: Add ftcolor.c to imported freetype sources
8293672: Update freetype md file
8316028: Update FreeType to 2.13.2
8306881: Update FreeType to 2.13.0

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title backport 67dd8a8d6a3f069f11d8e1492a775892f1f49829 8285686: Update FreeType to 2.12.0 Nov 28, 2025
@openjdk
Copy link

openjdk bot commented Nov 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Nov 28, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2025

Webrevs

@judovana judovana changed the title 8285686: Update FreeType to 2.12.0 backport 5f79e3ba8a06694f1445c02aca19445c567d2c9c Nov 28, 2025
@openjdk openjdk bot changed the title backport 5f79e3ba8a06694f1445c02aca19445c567d2c9c 8290334: Update FreeType to 2.12.1 Nov 28, 2025
@openjdk
Copy link

openjdk bot commented Nov 28, 2025

This backport pull request has now been updated with issue from the original commit.

@judovana judovana changed the title 8290334: Update FreeType to 2.12.1 backport 54cb9727180a81cf5458124fd253fa391e7cf421 Nov 28, 2025
@openjdk openjdk bot changed the title backport 54cb9727180a81cf5458124fd253fa391e7cf421 8298974: Add ftcolor.c to imported freetype sources Nov 28, 2025
@openjdk
Copy link

openjdk bot commented Nov 28, 2025

This backport pull request has now been updated with issue from the original commit.

without:
--- jdk/make/lib/Awt2dLibraries.gmk
+++ jdk/make/lib/Awt2dLibraries.gmk
@@ -527,6 +527,7 @@ else
          E_END_OF_LOOP_CODE_NOT_REACHED, \
       DISABLED_WARNINGS_microsoft := 4018 4267 4244 4312 4819, \
       DISABLED_WARNINGS_gcc := implicit-fallthrough cast-function-type bad-function-cast, \
+      DISABLED_WARNINGS_clang := missing-declarations, \
       LDFLAGS := $(LDFLAGS_JDKLIB) \
           $(call SET_SHARED_LIBRARY_ORIGIN), \
   ))
@judovana judovana changed the title 8298974: Add ftcolor.c to imported freetype sources backport c844a55f2f9b75c3edf2750f7a67a5edb6b635eb Nov 28, 2025
@openjdk openjdk bot changed the title backport c844a55f2f9b75c3edf2750f7a67a5edb6b635eb 8306881: Update FreeType to 2.13.0 Nov 28, 2025
@openjdk
Copy link

openjdk bot commented Nov 28, 2025

This backport pull request has now been updated with issue from the original commit.

@judovana
Copy link
Contributor Author

/issue add 8285686 8290334 8298974 8293672 8306881 8316028 8348596

@openjdk
Copy link

openjdk bot commented Nov 28, 2025

@judovana
Adding additional issue to issue list: 8285686: Update FreeType to 2.12.0.

Adding additional issue to issue list: 8290334: Update FreeType to 2.12.1.

Adding additional issue to issue list: 8298974: Add ftcolor.c to imported freetype sources.

Adding additional issue to issue list: 8293672: Update freetype md file.
This issue is referenced in the PR title - it will now be updated.

Adding additional issue to issue list: 8316028: Update FreeType to 2.13.2.

Adding additional issue to issue list: 8348596: Update FreeType to 2.13.3.

@judovana
Copy link
Contributor Author

/approval request It would be nice to have freetype aligned with other JDKs. It meansd to move jdk8 up to 2.13.3 before next release

@openjdk
Copy link

openjdk bot commented Nov 28, 2025

@judovana
8306881: The approval request has been created successfully.
8285686: The approval request has been created successfully.
8290334: The approval request has been created successfully.
8298974: The approval request has been created successfully.
8293672: The approval request has been created successfully.
8316028: The approval request has been created successfully.
8348596: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 28, 2025
@judovana judovana changed the title 8306881: Update FreeType to 2.13.0 backport 234d2f066d699679ccd6d6580fb09b7cb15d52c5 Nov 28, 2025
@openjdk openjdk bot changed the title backport 234d2f066d699679ccd6d6580fb09b7cb15d52c5 8316028: Update FreeType to 2.13.2 Nov 28, 2025
@openjdk
Copy link

openjdk bot commented Nov 28, 2025

This backport pull request has now been updated with issue from the original commit.

@judovana judovana changed the title 8316028: Update FreeType to 2.13.2 backport 428c2a292a8670f44bdb617014caaed0de591907 Nov 28, 2025
@openjdk openjdk bot changed the title backport 428c2a292a8670f44bdb617014caaed0de591907 8348596: Update FreeType to 2.13.3 Nov 28, 2025
@openjdk
Copy link

openjdk bot commented Nov 28, 2025

This backport pull request has now been updated with issue from the original commit.

@judovana
Copy link
Contributor Author

/issue add 8285686 8290334 8298974 8293672 8306881 8316028 8348596

@openjdk
Copy link

openjdk bot commented Nov 28, 2025

@judovana
Updating description of additional solved issue: 8285686: Update FreeType to 2.12.0.

Updating description of additional solved issue: 8290334: Update FreeType to 2.12.1.

Updating description of additional solved issue: 8298974: Add ftcolor.c to imported freetype sources.

Updating description of additional solved issue: 8293672: Update freetype md file.

Adding additional issue to issue list: 8306881: Update FreeType to 2.13.0.

Updating description of additional solved issue: 8316028: Update FreeType to 2.13.2.
This issue is referenced in the PR title - it will now be updated.

@judovana
Copy link
Contributor Author

Only runtime/containers/docker/TestCPUAwareness.java in the GHas


%% This notice is provided with respect to Freetype v2.9 which may be
included with JRE 8, JDK 8, and OpenJDK 8.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version in the title %% This notice is provided with respect to Freetype v2.9 should also be updated to v2.13.3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx! You have sharp eye. This was added in initial commit, and is not appearing in other JDKs (due to lack of THIR_PARTY_README). Will fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. The changes LGTM now.
Unfortunately, I'm not a reviewer, so I can't approve them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. The changes LGTM now. Unfortunately, I'm not a reviewer, so I can't approve them.

Thank you! I believe it is on Andrew's list for rampdownn

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I'm going to look at it now. @kvergizova thanks for looking at this and catching that issue. Please feel free to at least do a GitHub review so you are credited in the commit message, even though it won't count as a 'Reviewer' to allow the change through.

This notice is now provided for v2.13.3
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good against the 11u commits. I missed that the version was referenced in THIRD_PARTY_README when reviewing the last PR so thanks to @kvergizova for catching that.

@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Dec 5, 2025

@gnu-andrew
8348596: The approval request has been approved.
8285686: The approval request has been approved.
8290334: The approval request has been approved.
8298974: The approval request has been approved.
8293672: The approval request has been approved.
8316028: The approval request has been approved.
8306881: The approval request has been approved.

@judovana
Copy link
Contributor Author

judovana commented Dec 5, 2025

/integrate

@openjdk openjdk bot added ready Pull request is ready to be integrated sponsor Pull request is ready to be sponsored and removed approval Requires approval; will be removed when approval is received labels Dec 5, 2025
@openjdk
Copy link

openjdk bot commented Dec 5, 2025

@judovana
Your change (at version 2e8b3ec) is now ready to be sponsored by a Committer.

@gnu-andrew
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 5, 2025

Going to push as commit de76f06.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 5, 2025
@openjdk openjdk bot closed this Dec 5, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 5, 2025
@openjdk
Copy link

openjdk bot commented Dec 5, 2025

@gnu-andrew @judovana Pushed as commit de76f06.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants