Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8194154: System property user.dir should not be changed #8

Closed
wants to merge 1 commit into from

Conversation

dongbohe
Copy link
Member

@dongbohe dongbohe commented Mar 17, 2022

Hi,

Please review the backport of JDK-8194154 to 8u.
Bug: https://bugs.openjdk.java.net/browse/JDK-8194154
Original commit: http://hg.openjdk.java.net/jdk/jdk/rev/847a988152b8
8u webrev: https://cr.openjdk.java.net/~dongbohe/8194154/webrev.00/

Patch doesn't apply cleanly but is trivial, because JDK-8154231[1] and JDK-8155775[2] does not exist in 8,
and some copyright year conflicts.

Testing: checked that added test fails without the patch and passes with the patch, tested with tier1.

[1] https://bugs.openjdk.java.net/browse/JDK-8154231
[2] https://bugs.openjdk.java.net/browse/JDK-8155775

Original RFR email: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-January/014497.html

Thanks,
hedongbo


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8194154: System property user.dir should not be changed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/8/head:pull/8
$ git checkout pull/8

Update a local copy of the PR:
$ git checkout pull/8
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/8/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8

View PR using the GUI difftool:
$ git pr show -t 8

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/8.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 17, 2022

👋 Welcome back dongbohe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 17, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 17, 2022

Webrevs

@jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Mar 17, 2022

@dongbohe Skara tooling doesn't recognize this as a backport. Please use Backport 4ea684bf31fc4e3cdee2ae51c0000a7b3e914151 as the PR title, which should make this so.

@jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Mar 17, 2022

PR title (in the UI), not commit message :)

@dongbohe dongbohe changed the title 8194154: System property user.dir should not be changed Backport 4ea684bf31fc4e3cdee2ae51c0000a7b3e914151 Mar 17, 2022
@openjdk openjdk bot changed the title Backport 4ea684bf31fc4e3cdee2ae51c0000a7b3e914151 8194154: System property user.dir should not be changed Mar 17, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2022

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added the backport label Mar 17, 2022
@dongbohe
Copy link
Member Author

@dongbohe dongbohe commented Mar 17, 2022

PR title (in the UI), not commit message :)

Thanks for correcting me.

Copy link
Contributor

@jerboaa jerboaa left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2022

@dongbohe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8194154: System property user.dir should not be changed

Cached user.dir so getCanonicalPath uses the cached value.

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 94cb2ef: 8076190: Customizing the generation of a PKCS12 keystore

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 17, 2022
@dongbohe
Copy link
Member Author

@dongbohe dongbohe commented Mar 18, 2022

Thank you for your review, Severin. Tagged the JBS issue with jdk8u-fix-request.

@dongbohe
Copy link
Member Author

@dongbohe dongbohe commented Mar 21, 2022

/integrate

@openjdk openjdk bot added the sponsor label Mar 21, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 21, 2022

@dongbohe
Your change (at version d0d7c4a) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

@RealFYang RealFYang commented Mar 21, 2022

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Mar 21, 2022

Going to push as commit 5fcfb7a.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 94cb2ef: 8076190: Customizing the generation of a PKCS12 keystore

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 21, 2022
@openjdk openjdk bot closed this Mar 21, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Mar 21, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 21, 2022

@RealFYang @dongbohe Pushed as commit 5fcfb7a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
3 participants