8286582: Build fails on macos aarch64 when using --with-zlib=bundled

[mrserb]

Hi all,
This pull request contains a backport of commit 50d47de8 from the openjdk/jdk repository.
The commit being backported was authored by Jaikiran Pai on 12 May 2022 and was reviewed by Magnus Ihse Bursie and Lance Andersen.

The patch for JDK8 is slightly different:

• The main code patch is moved from the make/autoconf/lib-bundled.m4 to the jdk/make/lib/CoreLibraries.gmk the same place where ":= -lz" option is set.
• All disabled warnings are removed from the patch, seems we do not have such DISABLED_WARNINGS_XX in JDK8

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8286582: Build fails on macos aarch64 when using --with-zlib=bundled

Reviewers

• Paul Hohensee (@phohensee - Reviewer) ⚠️ Review applies to 5b2db66e
• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/80/head:pull/80
$ git checkout pull/80

Update a local copy of the PR:
$ git checkout pull/80
$ git pull https://git.openjdk.org/jdk8u-dev pull/80/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 80

View PR using the GUI difftool:
$ git pr show -t 80

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/80.diff

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (cd2f7444)
• 00: Full (5b2db66e)

[phohensee]

Lgtm.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8286582: Build fails on macos aarch64 when using --with-zlib=bundled

Reviewed-by: phh, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 17fd40a: 8295714: GHA ::set-output is deprecated and will be removed
• 2f509c7: 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
• f6d869f: 8221529: [TESTBUG] Docker tests use old/deprecated image on AArch64
• 3bfde7d: 8284622: Update versions of some Github Actions used in JDK workflow
• 3a1a2e0: 8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS
• 736c1fb: 8295288: Some vm_flags tests associate with a wrong BugID
• 0f9095f: 7124218: [TEST_BUG] [macosx] Space should select cell in the JTable
• 6e563e5: 8159720: Failure of C2 compilation with tiered prevents some C1 compilations
• 01f7d1e: 8224506: [TESTBUG] TestDockerMemoryMetrics.java fails with exitValue = 137
• c605aa3: 8296555: Enable hotspot/tier1 for 64-bit builds in GHA for 8u
• ... and 5 more: https://git.openjdk.org/jdk8u-dev/compare/f04ad96cf53385c9f8aa071a4167ad7790cb8466...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@mrserb This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[jerboaa]

@mrserb This is not being recognized as a backport. Please fix that.

[gnu-andrew]

Change itself looks ok, but title needs to be changed to "Backport 8363d9db801314f13e708db62993da5b73634f69" for the backport to be correctly identified.

Please reopen and fix this.

[mrserb]

/open

[openjdk]

@mrserb This pull request is now open

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mrserb]

@gnu-andrew please take a look, PR is update to have a backport label.

[jerboaa]

Looks OK.

[mrserb]

/integrate

[openjdk]

Going to push as commit 7ae002c.
Since your change was applied there have been 17 commits pushed to the master branch:

• 6849667: 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer
• 7024bf0: 8296959: Fix hotspot shell tests of 8u on multilib systems
• 17fd40a: 8295714: GHA ::set-output is deprecated and will be removed
• 2f509c7: 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
• f6d869f: 8221529: [TESTBUG] Docker tests use old/deprecated image on AArch64
• 3bfde7d: 8284622: Update versions of some Github Actions used in JDK workflow
• 3a1a2e0: 8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS
• 736c1fb: 8295288: Some vm_flags tests associate with a wrong BugID
• 0f9095f: 7124218: [TEST_BUG] [macosx] Space should select cell in the JTable
• 6e563e5: 8159720: Failure of C2 compilation with tiered prevents some C1 compilations
• ... and 7 more: https://git.openjdk.org/jdk8u-dev/compare/f04ad96cf53385c9f8aa071a4167ad7790cb8466...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit 7ae002c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.