-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8288928: Incorrect GPL header in pnglibconf.h (backport of JDK-8185041) #81
Conversation
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@mrserb This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 52 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/issue add 8288928 |
@mrserb This issue is referenced in the PR title - it will now be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport looks good
8u-dev is currently closed for rampdown so please wait until it reopens before integrating.
/reviewers 2 reviewer |
@gnu-andrew |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8u-dev now open for commits.
@mrserb This is not being recognized as a backport. Please use |
/integrate |
Going to push as commit ba408e5.
Your commit was automatically rebased without conflicts. |
Hi all,
This pull request contains a backport of commit 70762d39 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 7 Oct 2019 and was reviewed by Phil Race.
Thanks!
Backport is clean, but I have to create a new JBS issue, the initial one is closed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/81/head:pull/81
$ git checkout pull/81
Update a local copy of the PR:
$ git checkout pull/81
$ git pull https://git.openjdk.org/jdk8u-dev pull/81/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 81
View PR using the GUI difftool:
$ git pr show -t 81
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/81.diff