Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288928: Incorrect GPL header in pnglibconf.h (backport of JDK-8185041) #81

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 28, 2022

Hi all,
This pull request contains a backport of commit 70762d39 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 7 Oct 2019 and was reviewed by Phil Race.
Thanks!

Backport is clean, but I have to create a new JBS issue, the initial one is closed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issue

  • JDK-8288928: Incorrect GPL header in pnglibconf.h (backport of JDK-8185041) ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/81/head:pull/81
$ git checkout pull/81

Update a local copy of the PR:
$ git checkout pull/81
$ git pull https://git.openjdk.org/jdk8u-dev pull/81/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 81

View PR using the GUI difftool:
$ git pr show -t 81

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/81.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 28, 2022

⚠️ @mrserb the issue with id 8185041 from commit 70762d397267f85ce81727ec0c89c9448967798e does not exist in project JDK.

@mrserb mrserb changed the title Backport 70762d397267f85ce81727ec0c89c9448967798e 8288928: Incorrect GPL header in pnglibconf.h Jun 28, 2022
@mrserb mrserb marked this pull request as ready for review June 28, 2022 06:29
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 28, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 28, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jun 28, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8288928: Incorrect GPL header in pnglibconf.h (backport of JDK-8185041)

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 28, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2022

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

mrserb commented Aug 3, 2022

/issue add 8288928

@openjdk openjdk bot changed the title 8288928: Incorrect GPL header in pnglibconf.h 8288928: Incorrect GPL header in pnglibconf.h (backport of JDK-8185041) Aug 3, 2022
@openjdk
Copy link

openjdk bot commented Aug 3, 2022

@mrserb This issue is referenced in the PR title - it will now be updated.

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good
8u-dev is currently closed for rampdown so please wait until it reopens before integrating.

@gnu-andrew
Copy link
Member

/reviewers 2 reviewer

@openjdk
Copy link

openjdk bot commented Aug 31, 2022

@gnu-andrew
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Aug 31, 2022
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8u-dev now open for commits.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 1, 2022
@jerboaa
Copy link
Contributor

jerboaa commented Sep 1, 2022

@mrserb This is not being recognized as a backport. Please use Backport 39ec43618136abffdd071b066dc9a5d56317348b as the PR title and it should be detected appropriately. Failing that, Backport JDK-8288928 might work too.

@mrserb
Copy link
Member Author

mrserb commented Sep 7, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Sep 7, 2022

Going to push as commit ba408e5.
Since your change was applied there have been 55 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 7, 2022
@openjdk openjdk bot closed this Sep 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 7, 2022
@openjdk
Copy link

openjdk bot commented Sep 7, 2022

@mrserb Pushed as commit ba408e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8288928 branch September 7, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants