Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273176: handle latest VS2019 in abstract_vm_version #82

Closed
wants to merge 1 commit into from
Closed

8273176: handle latest VS2019 in abstract_vm_version #82

wants to merge 1 commit into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Jul 11, 2022

Hi! Here is another backport from MSVS 2019 seria. This one additionally extends the list of supported VC++ compilers. The patch from 11u is applied cleanly except the path shuffling:

src/hotspot/share/runtime/abstract_vm_version.cpp -> hotspot/src/share/vm/runtime/vm_version.cpp


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273176: handle latest VS2019 in abstract_vm_version

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/82/head:pull/82
$ git checkout pull/82

Update a local copy of the PR:
$ git checkout pull/82
$ git pull https://git.openjdk.org/jdk8u-dev pull/82/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 82

View PR using the GUI difftool:
$ git pr show -t 82

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/82.diff

Backport-of: 0e14bf70cf6e482a2ec7d13ed37df0bee911740d
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2022

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0e14bf70cf6e482a2ec7d13ed37df0bee911740d 8273176: handle latest VS2019 in abstract_vm_version Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 11, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 11, 2022

Webrevs

@yan-too
Copy link
Contributor

yan-too commented Jul 11, 2022

/clean

@openjdk openjdk bot added the clean label Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@yan-too This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@apavlyutkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273176: handle latest VS2019 in abstract_vm_version

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • 2be37c3: 8292762: Remove .jcheck directories from jdk8u subcomponents
  • bd946fa: 8274840: Update OS detection code to recognize Windows 11
  • 266918d: 8071530: Update OS detection code to reflect Windows 10 version change
  • 0d5ea9d: 8292688: Support Security properties in security.testlibrary.Proc
  • 026a6c5: 7131823: bug in GIFImageReader
  • d102764: 8139668: Generate README-build.html from markdown
  • de32daa: 8173339: AArch64: Fix minimum stack size computations
  • 2223058: 8049228: Improve multithreaded scalability of InetAddress cache
  • d0ad242: 8285497: Add system property for Java SE specification maintenance version
  • e3251a2: 8232950: SUNPKCS11 Provider incorrectly check key length for PSS Signatures.
  • ... and 32 more: https://git.openjdk.org/jdk8u-dev/compare/4f7dd0ca1625e9b870174ee21f9423cb4ff7ae09...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 11, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 8, 2022

@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@apavlyutkin
Copy link
Contributor Author

ping

@apavlyutkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 30, 2022
@openjdk
Copy link

openjdk bot commented Aug 30, 2022

@apavlyutkin
Your change (at version 4000c76) is now ready to be sponsored by a Committer.

@gnu-andrew
Copy link
Member

8u-dev is currently closed for rampdown.
Please do not integrate this PR until it is reopened.

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean backport.

@gnu-andrew
Copy link
Member

8u-dev now open for commits again.

@gnu-andrew
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 1, 2022

Going to push as commit 65b1748.
Since your change was applied there have been 43 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 1, 2022
@openjdk openjdk bot closed this Sep 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 1, 2022
@openjdk
Copy link

openjdk bot commented Sep 1, 2022

@gnu-andrew @apavlyutkin Pushed as commit 65b1748.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants