-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8273176: handle latest VS2019 in abstract_vm_version #82
Conversation
Backport-of: 0e14bf70cf6e482a2ec7d13ed37df0bee911740d
👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/clean |
@yan-too This backport pull request is now marked as clean |
@apavlyutkin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 42 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
ping |
/integrate |
@apavlyutkin |
8u-dev is currently closed for rampdown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean backport.
8u-dev now open for commits again. |
/sponsor |
Going to push as commit 65b1748.
Your commit was automatically rebased without conflicts. |
@gnu-andrew @apavlyutkin Pushed as commit 65b1748. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi! Here is another backport from MSVS 2019 seria. This one additionally extends the list of supported VC++ compilers. The patch from 11u is applied cleanly except the path shuffling:
src/hotspot/share/runtime/abstract_vm_version.cpp -> hotspot/src/share/vm/runtime/vm_version.cpp
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/82/head:pull/82
$ git checkout pull/82
Update a local copy of the PR:
$ git checkout pull/82
$ git pull https://git.openjdk.org/jdk8u-dev pull/82/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 82
View PR using the GUI difftool:
$ git pr show -t 82
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/82.diff