New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8254178: Remove .hgignore #83
Conversation
👋 Welcome back gdams! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@gdams This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 23 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @gnu-andrew) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@phohensee would you mind adding the fix request label to the issue on my behalf? |
Done. |
Mailing list message from Thorsten Glaser on jdk8u-dev: There?s also still the .hgtags file. bye, **************************************************** |
That would be a backport of JDK-8254318. |
Yeah I'll backport that one separately |
@gdams This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for catching all the instances in the old subrepos. We should also clean up the .jcheck
directories in those subdirectories. I doubt there is a backport for that one, so it would likely have to be an 8u bug.
Approved for 8u.
/integrate |
Thanks for the review @gnu-andrew please can you sponsor this? |
@phohensee I've covered this in #108 |
/sponsor |
Going to push as commit 5323ef6.
Your commit was automatically rebased without conflicts. |
@phohensee @gdams Pushed as commit 5323ef6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I would have, but Paul beat me to it :) Sadly, you can't do the sponsorship until integrate is run. |
@gnu-andrew please see #110 (and JDK-8292762) |
backports https://bugs.openjdk.org/browse/JDK-8254178 as it's a low-risk change
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/83/head:pull/83
$ git checkout pull/83
Update a local copy of the PR:
$ git checkout pull/83
$ git pull https://git.openjdk.org/jdk8u-dev pull/83/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 83
View PR using the GUI difftool:
$ git pr show -t 83
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/83.diff