Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254178: Remove .hgignore #83

Closed
wants to merge 1 commit into from
Closed

8254178: Remove .hgignore #83

wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 11, 2022

backports https://bugs.openjdk.org/browse/JDK-8254178 as it's a low-risk change


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/83/head:pull/83
$ git checkout pull/83

Update a local copy of the PR:
$ git checkout pull/83
$ git pull https://git.openjdk.org/jdk8u-dev pull/83/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 83

View PR using the GUI difftool:
$ git pr show -t 83

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/83.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2022

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 736e077335ec53c3804537a6abefa79087efd3ad 8254178: Remove .hgignore Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 11, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 11, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jul 13, 2022

@gdams This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8254178: Remove .hgignore

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 13, 2022
@gdams
Copy link
Member Author

gdams commented Jul 13, 2022

@phohensee would you mind adding the fix request label to the issue on my behalf?

@phohensee
Copy link
Member

Done.

@mlbridge
Copy link

mlbridge bot commented Jul 14, 2022

Mailing list message from Thorsten Glaser on jdk8u-dev:

There?s also still the .hgtags file.

bye,
//mirabilos
--
Infrastrukturexperte ? tarent solutions GmbH
Am Dickobskreuz 10, D-53121 Bonn ? http://www.tarent.de/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 5168 ? USt-ID (VAT): DE122264941
Gesch?ftsf?hrer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg

****************************************************
/?\ The UTF-8 Ribbon
??? Campaign against Mit dem tarent-Newsletter nichts mehr verpassen:
??? HTML eMail! Also, https://www.tarent.de/newsletter
??? header encryption!
****************************************************

@phohensee
Copy link
Member

That would be a backport of JDK-8254318.

@gdams
Copy link
Member Author

gdams commented Jul 14, 2022

Yeah I'll backport that one separately

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2022

@gdams This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for catching all the instances in the old subrepos. We should also clean up the .jcheck directories in those subdirectories. I doubt there is a backport for that one, so it would likely have to be an 8u bug.
Approved for 8u.

@gdams
Copy link
Member Author

gdams commented Aug 22, 2022

/integrate

@gdams
Copy link
Member Author

gdams commented Aug 22, 2022

Thanks for the review @gnu-andrew please can you sponsor this?

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 22, 2022
@openjdk
Copy link

openjdk bot commented Aug 22, 2022

@gdams
Your change (at version dfc9447) is now ready to be sponsored by a Committer.

@gdams
Copy link
Member Author

gdams commented Aug 22, 2022

That would be a backport of JDK-8254318.

@phohensee I've covered this in #108

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 22, 2022

Going to push as commit 5323ef6.
Since your change was applied there have been 23 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 22, 2022
@openjdk openjdk bot closed this Aug 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 22, 2022
@openjdk
Copy link

openjdk bot commented Aug 22, 2022

@phohensee @gdams Pushed as commit 5323ef6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gdams gdams deleted the hgignore branch August 22, 2022 12:43
@gnu-andrew
Copy link
Member

Thanks for the review @gnu-andrew please can you sponsor this?

I would have, but Paul beat me to it :) Sadly, you can't do the sponsorship until integrate is run.

@gdams
Copy link
Member Author

gdams commented Aug 23, 2022

We should also clean up the .jcheck directories in those subdirectories. I doubt there is a backport for that one, so it would likely have to be an 8u bug.

@gnu-andrew please see #110 (and JDK-8292762)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants