Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288865: [aarch64] LDR instructions must use legitimized addresses #84

Closed
wants to merge 3 commits into from
Closed

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Jul 20, 2022

Hi! Here is a backport fixing offset large offsets on memory reading by Unsafe API for Aarch64. Except 11->8 path suffling the fix applied with the only change: only LDR-related part of the test is being backported cuz 8u-dev already has got STR-related one.

Verification (Ubuntu 18.04.6 LTS (GNU/Linux 4.9.0 aarch64)):

hotspot/test/compiler/8235385/NonVolatileMemoryAccessWithLongOffset.java

10 of 10 runs PASS (5 of 10 runs FAILED before the patch applied)

Regression: hotspot/test/compiler

@theRealAph could you take a look, it's almost clean except the fact that STR-related part of test already presents in 8u-dev


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288865: [aarch64] LDR instructions must use legitimized addresses

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/84/head:pull/84
$ git checkout pull/84

Update a local copy of the PR:
$ git checkout pull/84
$ git pull https://git.openjdk.org/jdk8u-dev pull/84/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 84

View PR using the GUI difftool:
$ git pr show -t 84

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/84.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 20, 2022

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1f4028960a3934853104efd1d95991b137b5f520 8288865: [aarch64] LDR instructions must use legitimized addresses Jul 20, 2022
@openjdk
Copy link

openjdk bot commented Jul 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 20, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 20, 2022

Webrevs

Copy link
Contributor

@adinn adinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Even the spelling mistakes are consistent with those in jdk11u.

@openjdk
Copy link

openjdk bot commented Jul 20, 2022

@apavlyutkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8288865: [aarch64] LDR instructions must use legitimized addresses

Reviewed-by: adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@adinn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 20, 2022
@apavlyutkin
Copy link
Contributor Author

@jerboaa could you look at this one and approve if it's Ok? Thank you

@jerboaa
Copy link
Contributor

jerboaa commented Aug 4, 2022

I'll let @theRealAph approve this one.

@apavlyutkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 4, 2022
@openjdk
Copy link

openjdk bot commented Aug 4, 2022

@apavlyutkin
Your change (at version c5050b7) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Aug 4, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 4, 2022

Going to push as commit deae94f.
Since your change was applied there have been 16 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 4, 2022
@openjdk openjdk bot closed this Aug 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 4, 2022
@openjdk
Copy link

openjdk bot commented Aug 4, 2022

@jerboaa @apavlyutkin Pushed as commit deae94f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants