Skip to content

8290000: Bump macOS GitHub actions to macOS 11 #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 21, 2022

macOS 10.15 has been deprecated for some time and will be removed completely on August 30th. See https://github.com/actions/virtual-environments#available-environments and actions/runner-images#5583 for context.

This PR doesn't apply cleanly because it was added to the GitHub actions rewrite in tip. As it's unlikely that I will have a backported rewrite by August 30th my preference is to backport this way round.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/87/head:pull/87
$ git checkout pull/87

Update a local copy of the PR:
$ git checkout pull/87
$ git pull https://git.openjdk.org/jdk8u-dev pull/87/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 87

View PR using the GUI difftool:
$ git pr show -t 87

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/87.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2022

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4e6cd67fec3d978f4c8c1aed95a1d09b544eff68 8290000: Bump macOS GitHub actions to macOS 11 Jul 21, 2022
@openjdk
Copy link

openjdk bot commented Jul 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 21, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2022

Webrevs

@openjdk-notifier
Copy link

@gdams Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me and GHA seems happy. Thumbs up!

@openjdk
Copy link

openjdk bot commented Aug 3, 2022

@gdams This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8290000: Bump macOS GitHub actions to macOS 11

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 1460bfa: Merge
  • 2dadc2b: 8290832: It is no longer possible to change "user.dir" in the JDK8
  • 244f98e: 8291568: Bump update version of OpenJDK: 8u345

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 3, 2022
@gdams
Copy link
Member Author

gdams commented Aug 3, 2022

/integrate

@gdams
Copy link
Member Author

gdams commented Aug 3, 2022

Fix request is complete. @jerboaa are you willing to sponsor the change?

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 3, 2022
@openjdk
Copy link

openjdk bot commented Aug 3, 2022

@gdams
Your change (at version 08cb4aa) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 4, 2022

Going to push as commit 39fa6fb.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 1460bfa: Merge
  • 2dadc2b: 8290832: It is no longer possible to change "user.dir" in the JDK8
  • 244f98e: 8291568: Bump update version of OpenJDK: 8u345

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 4, 2022
@openjdk openjdk bot closed this Aug 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 4, 2022
@openjdk
Copy link

openjdk bot commented Aug 4, 2022

@RealCLanger @gdams Pushed as commit 39fa6fb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants