8290832: It is no longer possible to change "user.dir" in the JDK8

[mrserb]

This is the request to revert the fix for JDK-8194154 integrated to the openjdk8u342

The fix for JDK-8194154 disabled the possibility to change the "user.dir" property.
Changing the "user.dir" was not recommended from the beginning but it was not forbidden, so there are some old applications that rely on the old behavior.

For compatibility reasons, it would be good to restore the old behavior.

Note that the test is simplified and saved under a different name, now it will check just the possibility to change the 'user.dir' using a simple path and name.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290832: It is no longer possible to change "user.dir" in the JDK8

Reviewers

• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/88/head:pull/88
$ git checkout pull/88

Update a local copy of the PR:
$ git checkout pull/88
$ git pull https://git.openjdk.org/jdk8u-dev pull/88/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 88

View PR using the GUI difftool:
$ git pr show -t 88

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/88.diff

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (b2d52666)
• 00: Full (1f51111d)

[dsamersoff]

Looks good to me.

[RealCLanger]

The change itself looks good. But wouldn't it be better to do a clean backout of JDK-8194154 and then add the test that user.dir can be changed in JDK8 with a different issue?

Or would it at least be possible that the test is not shown as renamed but rather as a deletion of the old test and the addition of a new test? (Not sure whether that's something that git did automatically or whether you can change this)

[mrserb]

Or would it at least be possible that the test is not shown as renamed but rather as a deletion of the old test and the addition of a new test? (Not sure whether that's something that git did automatically or whether you can change this)

It is actually a deletion in one commit and adding a new test by another, it is how the github shows it, but I can split it by different commits.

[mrserb]

The patch is updated as requested, the test will be pushed separately.

[openjdk-notifier]

@mrserb Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[RealCLanger]

LGTM. You might consider renaming the JBS issue to something like "Backout JDK-8194154..." But I leave that to your or the 8u maintainers.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8290832: It is no longer possible to change "user.dir" in the JDK8

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[gnu-andrew]

Thanks for catching this @mrserb and the patch itself looks like a clean backout to me.

However, I suggest we do this on https://github.com/openjdk/jdk8u for an interim 8u345 release. I've just requested that version from ops and will update the jcheck rules on 8u when that is created.

Presumably we'll do the test under a different bug?

[mrserb]

However, I suggest we do this on https://github.com/openjdk/jdk8u for an interim 8u345 release. I've just requested that version from ops and will update the jcheck rules on 8u when that is created.

Ok, I'll prepare the patch for that repo.

Presumably we'll do the test under a different bug?

Yes, I'll add the test in a separate CR, so this patch will be as simple as "git revert"..