Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290832: It is no longer possible to change "user.dir" in the JDK8 #88

Closed
wants to merge 3 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jul 21, 2022

This is the request to revert the fix for JDK-8194154 integrated to the openjdk8u342

The fix for JDK-8194154 disabled the possibility to change the "user.dir" property.
Changing the "user.dir" was not recommended from the beginning but it was not forbidden, so there are some old applications that rely on the old behavior.

For compatibility reasons, it would be good to restore the old behavior.

Note that the test is simplified and saved under a different name, now it will check just the possibility to change the 'user.dir' using a simple path and name.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290832: It is no longer possible to change "user.dir" in the JDK8

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/88/head:pull/88
$ git checkout pull/88

Update a local copy of the PR:
$ git checkout pull/88
$ git pull https://git.openjdk.org/jdk8u-dev pull/88/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 88

View PR using the GUI difftool:
$ git pr show -t 88

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/88.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 21, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mrserb mrserb marked this pull request as ready for review Jul 21, 2022
@openjdk openjdk bot added the rfr label Jul 21, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 21, 2022

Webrevs

@dsamersoff
Copy link

@dsamersoff dsamersoff commented Jul 22, 2022

Looks good to me.

Copy link
Contributor

@RealCLanger RealCLanger left a comment

The change itself looks good. But wouldn't it be better to do a clean backout of JDK-8194154 and then add the test that user.dir can be changed in JDK8 with a different issue?

Or would it at least be possible that the test is not shown as renamed but rather as a deletion of the old test and the addition of a new test? (Not sure whether that's something that git did automatically or whether you can change this)

@mrserb
Copy link
Member Author

@mrserb mrserb commented Jul 22, 2022

Or would it at least be possible that the test is not shown as renamed but rather as a deletion of the old test and the addition of a new test? (Not sure whether that's something that git did automatically or whether you can change this)

It is actually a deletion in one commit and adding a new test by another, it is how the github shows it, but I can split it by different commits.

@mrserb
Copy link
Member Author

@mrserb mrserb commented Jul 22, 2022

The patch is updated as requested, the test will be pushed separately.

@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented Jul 22, 2022

@mrserb Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

Copy link
Contributor

@RealCLanger RealCLanger left a comment

LGTM. You might consider renaming the JBS issue to something like "Backout JDK-8194154..." But I leave that to your or the 8u maintainers.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8290832: It is no longer possible to change "user.dir" in the JDK8

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 22, 2022
@mrserb mrserb changed the title JDK-8290832: It is no longer possible to change "user.dir" in the JDK8 8290832: It is no longer possible to change "user.dir" in the JDK8 Jul 22, 2022
@gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Jul 29, 2022

Thanks for catching this @mrserb and the patch itself looks like a clean backout to me.

However, I suggest we do this on https://github.com/openjdk/jdk8u for an interim 8u345 release. I've just requested that version from ops and will update the jcheck rules on 8u when that is created.

Presumably we'll do the test under a different bug?

@mrserb
Copy link
Member Author

@mrserb mrserb commented Jul 29, 2022

However, I suggest we do this on https://github.com/openjdk/jdk8u for an interim 8u345 release. I've just requested that version from ops and will update the jcheck rules on 8u when that is created.

Ok, I'll prepare the patch for that repo.

Presumably we'll do the test under a different bug?

Yes, I'll add the test in a separate CR, so this patch will be as simple as "git revert"..

@mrserb mrserb closed this Jul 31, 2022
@mrserb mrserb deleted the JDK-8290832 branch Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready rfr
4 participants