8173361: various crashes in JvmtiExport::post_compiled_method_load

[dongbohe]

Hi,

This PR has been reviewed before move to github: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-January/014487.html

Thanks,
hedongbo

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8173361: various crashes in JvmtiExport::post_compiled_method_load

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)
• Serguei Spitsyn - Committer ⚠️ Added manually

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/9/head:pull/9
$ git checkout pull/9

Update a local copy of the PR:
$ git checkout pull/9
$ git pull https://git.openjdk.org/jdk8u-dev pull/9/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9

View PR using the GUI difftool:
$ git pr show -t 9

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/9.diff

[bridgekeeper]

👋 Welcome back dongbohe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (dc346d25)
• 00: Full (4ce16b1a)

[dongbohe]

Hi,

Can I get another review from 8u reviewer?

[dongbohe]

/cc serviceability

[openjdk]

@dongbohe
The label serviceability is not a valid label.
These labels are valid:

[dongbohe]

/reviewer add sspitsyn

[openjdk]

@dongbohe Syntax: /reviewer (credit|remove) [@user | openjdk-user]+. For example:

• /reviewer credit @openjdk-bot
• /reviewer credit duke
• /reviewer credit @user1 @user2

[dongbohe]

/reviewer credit sspitsyn

[openjdk]

@dongbohe
Reviewer sspitsyn successfully credited.

[bridgekeeper]

@dongbohe This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[dongbohe]

ping...

[bridgekeeper]

@dongbohe This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[gnu-andrew]

This looks like a fairly clean backport. The only differences I see are NoSafepointVerifier and No_Safepoint_Verifier and the lack of the #ifndef USDT2 block in 8u.

Can you merge this with jdk8u-dev/master so that the GitHub build checks run? Thanks.

[dongbohe]

Thanks for picking this up, I also reopened #19 .

[gnu-andrew]

Build runs look good.

[openjdk]

@dongbohe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8173361: various crashes in JvmtiExport::post_compiled_method_load

Don't post information that uses metadata from unloaded nmethods

Reviewed-by: andrew, sspitsyn
Backport-of: b1d915ef80ebdf511dc2897b20ada78b3dc44241

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• cf6b628: 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*)
• 83e9095: 8280963: Incorrect PrintFlags formatting on Windows
• 820ab13: 8235385: Crash on aarch64 JDK due to long offset
• f3c87ce: 8287521: Bump update version of OpenJDK: 8u352

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[bridgekeeper]

@dongbohe This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[gnu-andrew]

I've approved the bug with jdk8u-fix-yes and can sponsor once you integrate.

[dongbohe]

/integrate

[openjdk]

@dongbohe
Your change (at version dc346d2) is now ready to be sponsored by a Committer.

[gnu-andrew]

/sponsor

[openjdk]

Going to push as commit 1b4f32d.
Since your change was applied there have been 4 commits pushed to the master branch:

• cf6b628: 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*)
• 83e9095: 8280963: Incorrect PrintFlags formatting on Windows
• 820ab13: 8235385: Crash on aarch64 JDK due to long offset
• f3c87ce: 8287521: Bump update version of OpenJDK: 8u352

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew @dongbohe Pushed as commit 1b4f32d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.