New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8274840: Update OS detection code to recognize Windows 11 #93
Conversation
👋 Welcome back rgithubli! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirm it is clean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/clean
Lgtm.
@rgithubli This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Don't close this yet, bot. |
/integrate |
@rgithubli This pull request has not yet been marked as ready for integration. |
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout win-bp-8274840
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@rgithubli This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 25 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/sponsor |
@jerboaa The change author (@rgithubli) must issue an |
@rgithubli I think we need to do the |
/integrate |
@rgithubli |
/sponsor |
Going to push as commit bd946fa.
Your commit was automatically rebased without conflicts. |
@jerboaa @rgithubli Pushed as commit bd946fa. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This pull request contains a backport of commit openjdk/jdk@97ea9dd
The original author is Matthias Baesken and co-authored by Arno Zeller. It was reviewed by clanger, dholmes.
The backport was clean after updating filepath.
Verified on win11: when doing
java -XshowSettings:properties -version
, can seeos.name = Windows 11
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/93/head:pull/93
$ git checkout pull/93
Update a local copy of the PR:
$ git checkout pull/93
$ git pull https://git.openjdk.org/jdk8u-dev pull/93/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 93
View PR using the GUI difftool:
$ git pr show -t 93
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/93.diff