8175797: (ref) Reference::enqueue method should clear the reference object before enqueuing

[poonamparhar]

These changes backport JDK-8175797 and two very closely related fixes (8178832 and 8193780) to jdk8u-dev:

8175797: (ref) Reference::enqueue method should clear the reference object before enqueuing
8178832: (ref) jdk.lang.ref.disableClearBeforeEnqueue property is ignored
8193780: (ref) Remove the undocumented jdk.lang.ref.disableClearBeforeEnqueue system property

With these changes, the enqueue method clears the reference before enqueuing it to the registered queue.

It is a clean port from jdk8u-ri.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8175797: (ref) Reference::enqueue method should clear the reference object before enqueuing
• JDK-8178832: (ref) jdk.lang.ref.disableClearBeforeEnqueue property is ignored
• JDK-8193780: (ref) Remove the undocumented "jdk.lang.ref.disableClearBeforeEnqueue" system property

Reviewers

• Mandy Chung (@mlchung - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)
• Iris Clark (@irisclark - Author)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/99/head:pull/99
$ git checkout pull/99

Update a local copy of the PR:
$ git checkout pull/99
$ git pull https://git.openjdk.org/jdk8u-dev pull/99/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 99

View PR using the GUI difftool:
$ git pr show -t 99

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/99.diff

[bridgekeeper]

👋 Welcome back poonam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issues from the original commit.

[openjdk]

@poonamparhar This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8175797: (ref) Reference::enqueue method should clear the reference object before enqueuing
8178832: (ref) jdk.lang.ref.disableClearBeforeEnqueue property is ignored
8193780: (ref) Remove the undocumented "jdk.lang.ref.disableClearBeforeEnqueue" system property

Reviewed-by: mchung, dholmes, iris, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 4cc462a: 8214427: probable bug in logic of ConcurrentHashMap.addCount()
• 645b6c8: 8288763: Pack200 extraction failure with invalid size
• 8e2c498: 8245263: Enable TLSv1.3 by default on JDK 8u for Client roles

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (78135ad7)

[dholmes-ora]

Looks good. Thanks.

[irisclark]

Spec changes match those in JSR 337 MR 4.

[gnu-andrew]

Makes sense to include 8178832 & 8193780 here to avoid including code only for it to be removed again by later commits.
Approved for 8u.

[poonamparhar]

/integrate

[openjdk]

Going to push as commit e633df1.
Since your change was applied there have been 4 commits pushed to the master branch:

• 5323ef6: 8254178: Remove .hgignore
• 4cc462a: 8214427: probable bug in logic of ConcurrentHashMap.addCount()
• 645b6c8: 8288763: Pack200 extraction failure with invalid size
• 8e2c498: 8245263: Enable TLSv1.3 by default on JDK 8u for Client roles

Your commit was automatically rebased without conflicts.

[openjdk]

@poonamparhar Pushed as commit e633df1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.