New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8175797: (ref) Reference::enqueue method should clear the reference object before enqueuing #99
Conversation
…bject before enqueuing
|
This backport pull request has now been updated with issues from the original commit. |
@poonamparhar This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spec changes match those in JSR 337 MR 4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to include 8178832 & 8193780 here to avoid including code only for it to be removed again by later commits.
Approved for 8u.
/integrate |
Going to push as commit e633df1.
Your commit was automatically rebased without conflicts. |
@poonamparhar Pushed as commit e633df1. |
These changes backport JDK-8175797 and two very closely related fixes (8178832 and 8193780) to jdk8u-dev:
With these changes, the enqueue method clears the reference before enqueuing it to the registered queue.
It is a clean port from jdk8u-ri.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/99/head:pull/99
$ git checkout pull/99
Update a local copy of the PR:
$ git checkout pull/99
$ git pull https://git.openjdk.org/jdk8u-dev pull/99/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 99
View PR using the GUI difftool:
$ git pr show -t 99
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/99.diff