-
Notifications
You must be signed in to change notification settings - Fork 7
8210283: Support git as an SCM alternative in the build #1
Conversation
|
👋 Welcome back erikj! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue and summary from the original commit. |
cbf95bb to
5b9006b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
@erikj79 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit dfcf70d. |
Update TestIsJavaIdentifierMethods to support 108 CJK E Code points
This is a backport of the changes needed to support building from Git repos. I've tried to keep the changes minimal. The patch differs quite a bit from the original jdk8u backport of this change, mainly in the parts that only really serve to interact with Oracle custom build logic, and likely aren't used by anyone in jdk8u main. For example, I chose to keep the existing .hgtip files instead of trying to rename them to something else (.gittip or .src-rev), as updating the external dependencies we have on these file names would be too much work for this release.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-ri pull/1/head:pull/1$ git checkout pull/1Update a local copy of the PR:
$ git checkout pull/1$ git pull https://git.openjdk.java.net/jdk8u-ri pull/1/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1View PR using the GUI difftool:
$ git pr show -t 1Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-ri/pull/1.diff