Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8210283: Support git as an SCM alternative in the build #1

Closed
wants to merge 1 commit into from

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented Apr 14, 2022

This is a backport of the changes needed to support building from Git repos. I've tried to keep the changes minimal. The patch differs quite a bit from the original jdk8u backport of this change, mainly in the parts that only really serve to interact with Oracle custom build logic, and likely aren't used by anyone in jdk8u main. For example, I chose to keep the existing .hgtip files instead of trying to rename them to something else (.gittip or .src-rev), as updating the external dependencies we have on these file names would be too much work for this release.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8210283: Support git as an SCM alternative in the build

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-ri pull/1/head:pull/1
$ git checkout pull/1

Update a local copy of the PR:
$ git checkout pull/1
$ git pull https://git.openjdk.java.net/jdk8u-ri pull/1/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1

View PR using the GUI difftool:
$ git pr show -t 1

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-ri/pull/1.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 14, 2022

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8210283 8210283: Support git as an SCM alternative in the build Apr 14, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 14, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 14, 2022

Webrevs

@erikj79 erikj79 changed the title 8210283: Support git as an SCM alternative in the build Backport 054b85b1f65254b2d3d2a1d343e14d8eabd1af40 Apr 14, 2022
@openjdk openjdk bot changed the title Backport 054b85b1f65254b2d3d2a1d343e14d8eabd1af40 8210283: Support git as an SCM alternative in the build Apr 14, 2022
@openjdk
Copy link

openjdk bot commented Apr 14, 2022

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added the backport label Apr 14, 2022
Copy link
Member

@tbell29552 tbell29552 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@openjdk
Copy link

openjdk bot commented Apr 15, 2022

@erikj79 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8210283: Support git as an SCM alternative in the build

Removes forest handling of SCM ids

Reviewed-by: mikael, tbell

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 15, 2022
@erikj79
Copy link
Member Author

erikj79 commented Apr 18, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 18, 2022

Going to push as commit dfcf70d.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 18, 2022
@openjdk openjdk bot closed this Apr 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 18, 2022
@openjdk
Copy link

openjdk bot commented Apr 18, 2022

@erikj79 Pushed as commit dfcf70d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk-notifier bot pushed a commit that referenced this pull request Apr 6, 2023
Update TestIsJavaIdentifierMethods to support 108 CJK E Code points
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants