Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301400: Allow additional characters for GB18030-2022 support #10

Closed
wants to merge 6 commits into from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Feb 21, 2023

Please review the changes to the Reference Implementation of the proposed Maintenance Release of the Java SE 8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2023-February/016710.html). The RI contains a portion of previously released Maintenance Release 2 of the Java SE 8 (Unicode Characters) updates as well. (https://jcp.org/aboutJava/communityprocess/maintenance/jsr337/jsr337-mr2-changes.html#s3)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8301557 to be approved

Issues

  • JDK-8301400: Allow additional characters for GB18030-2022 support
  • JDK-8301557: Allow additional characters for GB18030-2022 support (CSR)

Reviewers

Contributors

  • Justin Lu <jlu@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-ri pull/10/head:pull/10
$ git checkout pull/10

Update a local copy of the PR:
$ git checkout pull/10
$ git pull https://git.openjdk.org/jdk8u-ri pull/10/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10

View PR using the GUI difftool:
$ git pr show -t 10

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-ri/pull/10.diff

@naotoj
Copy link
Member Author

naotoj commented Feb 21, 2023

/contributor @justin-curtis-lu

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2023

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 21, 2023
@openjdk
Copy link

openjdk bot commented Feb 21, 2023

@naotoj Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

@naotoj
Copy link
Member Author

naotoj commented Feb 21, 2023

/contributor add @justin-curtis-lu

@openjdk
Copy link

openjdk bot commented Feb 21, 2023

@naotoj
Contributor Justin Lu <jlu@openjdk.org> successfully added.

@mlbridge
Copy link

mlbridge bot commented Feb 21, 2023

Webrevs

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look correct to me, assuming the new test passes.

Most of these changes are drawn from JDK-8211398 (the currency and Japanese era addition, and the new test) which made it to 8u211/212, but not a new reference implementation. I expect the changes for 8u382 will be simpler as they can just build on top of 8211398, as the separate commits here suggest.

@openjdk
Copy link

openjdk bot commented Feb 22, 2023

@naotoj This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8301400: Allow additional characters for GB18030-2022 support

Co-authored-by: Justin Lu <jlu@openjdk.org>
Reviewed-by: andrew, lancea, iris, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 9176874: 8303031: Set .jcheck/conf version for jdk8u43

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 22, 2023
@naotoj
Copy link
Member Author

naotoj commented Feb 22, 2023

Most of these changes are drawn from JDK-8211398 (the currency and Japanese era addition, and the new test) which made it to 8u211/212, but not a new reference implementation. I expect the changes for 8u382 will be simpler as they can just build on top of 8211398, as the separate commits here suggest.

Thanks, Andrew. Yes, it will be much simpler for the existing 8u line.

@gnu-andrew
Copy link
Member

Approved with jdk8u43-fix-yes

@naotoj
Copy link
Member Author

naotoj commented Mar 2, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 2, 2023

Going to push as commit a039f39.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 9176874: 8303031: Set .jcheck/conf version for jdk8u43

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 2, 2023
@openjdk openjdk bot closed this Mar 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 2, 2023
@openjdk
Copy link

openjdk bot commented Mar 2, 2023

@naotoj Pushed as commit a039f39.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
6 participants