Skip to content
This repository was archived by the owner on Oct 1, 2025. It is now read-only.

Conversation

@justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Feb 21, 2023

This PR updates the value of the system property: java.specification.maintenance.version from 4 to 5. This change is done towards the Reference Implementation of the proposed Java SE 8 Maintenance Release 5 (https://mail.openjdk.org/pipermail/jdk8u-dev/2023-February/016710.html).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303028: Update system property for Java SE specification maintenance version

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-ri pull/12/head:pull/12
$ git checkout pull/12

Update a local copy of the PR:
$ git checkout pull/12
$ git pull https://git.openjdk.org/jdk8u-ri pull/12/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12

View PR using the GUI difftool:
$ git pr show -t 12

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-ri/pull/12.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2023

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 21, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 21, 2023

@justin-curtis-lu This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8303028: Update system property for Java SE specification maintenance version

Reviewed-by: lancea, iris, naoto, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • a039f39: 8301400: Allow additional characters for GB18030-2022 support
  • 9176874: 8303031: Set .jcheck/conf version for jdk8u43

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@LanceAndersen, @naotoj, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 21, 2023
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with jdk8u43-fix-yes

@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 2, 2023
@openjdk
Copy link

openjdk bot commented Mar 2, 2023

@justin-curtis-lu
Your change (at version 7617180) is now ready to be sponsored by a Committer.

@naotoj
Copy link
Member

naotoj commented Mar 2, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 2, 2023

Going to push as commit 9eb797d.
Since your change was applied there have been 2 commits pushed to the master branch:

  • a039f39: 8301400: Allow additional characters for GB18030-2022 support
  • 9176874: 8303031: Set .jcheck/conf version for jdk8u43

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 2, 2023
@openjdk openjdk bot closed this Mar 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 2, 2023
@openjdk
Copy link

openjdk bot commented Mar 2, 2023

@naotoj @justin-curtis-lu Pushed as commit 9eb797d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

5 participants