Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307779: Relax the java.awt.Robot specification #15

Closed
wants to merge 3 commits into from

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Apr 24, 2024

Please review the doc only backport PR of openjdk/jdk#13809.

It is backport of the original commit + build failure fix.

8u does not have the changes related to the to the missing createMultiResolutionScreenCapture method.

CSR: JDK-8331038


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8331038 to be approved
  • JDK-8307779 needs maintainer approval

Issues

  • JDK-8307779: Relax the java.awt.Robot specification (Bug - P3 - Approved)
  • JDK-8331038: Relax the java.awt.Robot specification (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-ri.git pull/15/head:pull/15
$ git checkout pull/15

Update a local copy of the PR:
$ git checkout pull/15
$ git pull https://git.openjdk.org/jdk8u-ri.git pull/15/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15

View PR using the GUI difftool:
$ git pr show -t 15

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-ri/pull/15.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 24, 2024

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 24, 2024

@azvegint This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8307779: Relax the java.awt.Robot specification

Reviewed-by: prr, iris, lancea, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • dde7fde: 8331152: Update .jcheck/conf for 8u44

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 21aa057fafd88f4dd677bbf7c99a7eabb6b18409 8307779: Relax the java.awt.Robot specification Apr 24, 2024
@openjdk
Copy link

openjdk bot commented Apr 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 24, 2024
@openjdk
Copy link

openjdk bot commented Apr 24, 2024

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Apr 24, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 24, 2024

Webrevs

@openjdk openjdk bot added the approval label Apr 25, 2024
Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec and implementation changes as expected for 8u44.

Associated CSR (JDK-8331038 already Approved.

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, adapting for older copyright and context, and the lack of createMultiResolutionScreenCapture
Again, as with 17u, not sure if we should mention JDK-8308370 or not. We usually would for a regular 8u backport.

@openjdk openjdk bot removed the approval label Apr 25, 2024
@gnu-andrew
Copy link
Member

Change looks good, adapting for older copyright and context, and the lack of createMultiResolutionScreenCapture Again, as with 17u, not sure if we should mention JDK-8308370 or not. We usually would for a regular 8u backport.

8u also adds checkScreenCaptureAllowed as 11u does. I missed this earlier due to the documentation differences between 17 & 8.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Apr 26, 2024
@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 16, 2024

Going to push as commit c0a876a.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 4f3b76f: 8332085: Remove 10 year old transition check in GenerateCurrencyData tool
  • dde7fde: 8331152: Update .jcheck/conf for 8u44

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 16, 2024
@openjdk openjdk bot closed this May 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 16, 2024
@openjdk
Copy link

openjdk bot commented May 16, 2024

@azvegint Pushed as commit c0a876a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

5 participants