Skip to content
This repository was archived by the owner on Oct 1, 2025. It is now read-only.

Conversation

@erikj79
Copy link
Member

@erikj79 erikj79 commented Apr 25, 2024

The version number in .jcheck/conf needs to be updated for the new 8u44 release.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331152 needs maintainer approval

Issue

  • JDK-8331152: Update .jcheck/conf for 8u44 (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-ri.git pull/16/head:pull/16
$ git checkout pull/16

Update a local copy of the PR:
$ git checkout pull/16
$ git pull https://git.openjdk.org/jdk8u-ri.git pull/16/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16

View PR using the GUI difftool:
$ git pr show -t 16

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-ri/pull/16.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2024

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 25, 2024

@erikj79 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8331152: Update .jcheck/conf for 8u44

Reviewed-by: iris, lancea, prr, mullan, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8331152 8331152: Update .jcheck/conf for 8u44 Apr 25, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 25, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 25, 2024
@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed ready Pull request is ready to be integrated labels Apr 25, 2024
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct.

@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Apr 25, 2024

@gnu-andrew Only integrators for this repository are allowed to issue the /approve command.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Apr 25, 2024
@erikj79
Copy link
Member Author

erikj79 commented Apr 26, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 26, 2024

Going to push as commit dde7fde.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 26, 2024
@openjdk openjdk bot closed this Apr 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 26, 2024
@openjdk
Copy link

openjdk bot commented Apr 26, 2024

@erikj79 Pushed as commit dde7fde.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

6 participants