8284907: Compact profiles build fails with GNU make 4

[erikj79]

The compact profiles jar creation logic relies on what seems to be undefined behavior in GNU make. Pattern rules are unreliable when the file names contain '$'. The specific construct used in CreateJars.gmk works with GNU make 3.81, but fails with version 4 or higher.

This was originally fixed in 8u60 in JDK-8067857. That change is quite big and not something we want to backport to 8u42. However, since then, GNU make 4 and higher have become quite common on Linux too, and not just in Cygwin where I believe this problem was first encountered. Because of this, I would like to extract just the fix for this, exactly as it was done in JDK-8067857. Here is the original change:

openjdk/jdk8u-dev@17421c8#diff-e580e7e55e76622c538ae8a1b55af984b3e12bba099e493582fff2925b9ae02aR314-R322

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8284907: Compact profiles build fails with GNU make 4

Reviewers

• Tim Bell (@tbell29552 - Reviewer)
• Magnus Ihse Bursie (@magicus - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-ri pull/2/head:pull/2
$ git checkout pull/2

Update a local copy of the PR:
$ git checkout pull/2
$ git pull https://git.openjdk.java.net/jdk8u-ri pull/2/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2

View PR using the GUI difftool:
$ git pr show -t 2

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-ri/pull/2.diff

[bridgekeeper]

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (14c631ad)

[tbell29552]

Looks good

[openjdk]

@erikj79 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284907: Compact profiles build fails with GNU make 4

Reviewed-by: tbell, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• dfcf70d: 8210283: Support git as an SCM alternative in the build

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[erikj79]

/integrate

[openjdk]

Going to push as commit d63ed0a.
Since your change was applied there has been 1 commit pushed to the master branch:

• dfcf70d: 8210283: Support git as an SCM alternative in the build

Your commit was automatically rebased without conflicts.

[openjdk]

@erikj79 Pushed as commit d63ed0a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.