Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8079087: Add support for Cygwin 2.0 #3

Closed
wants to merge 4 commits into from

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented Apr 18, 2022

This is a backport of three Cygwin related fixes from jdk8u. In order to better facilitate development in jdk8u-ri, I would like to get these fixes in, so that developers may use recent versions of Cygwin as build environment for this repository. I'm not even sure it's possible to install a pre Cygwin 2.0 environment anymore. All three fixes have been used successfully in jdk8u for years.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-ri pull/3/head:pull/3
$ git checkout pull/3

Update a local copy of the PR:
$ git checkout pull/3
$ git pull https://git.openjdk.java.net/jdk8u-ri pull/3/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3

View PR using the GUI difftool:
$ git pr show -t 3

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-ri/pull/3.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2022

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@erikj79
Copy link
Member Author

erikj79 commented Apr 18, 2022

/issue add JDK-8176033
/issue add JDK-8179675

@openjdk openjdk bot changed the title 8079087 8079087: Add support for Cygwin 2.0 Apr 18, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 18, 2022
@openjdk
Copy link

openjdk bot commented Apr 18, 2022

@erikj79
Adding additional issue to issue list: 8176033: New cygwin grep does not match \r as newline.

@openjdk
Copy link

openjdk bot commented Apr 18, 2022

@erikj79
Adding additional issue to issue list: 8179675: Build with error on windows with new Cygwin grep.

@mlbridge
Copy link

mlbridge bot commented Apr 18, 2022

Webrevs

@erikj79 erikj79 changed the title 8079087: Add support for Cygwin 2.0 Backport a90ed05109da57e35b9c158cd9aac893f04a6af5 Apr 18, 2022
@openjdk openjdk bot changed the title Backport a90ed05109da57e35b9c158cd9aac893f04a6af5 8079087: Add support for Cygwin 2.0 Apr 18, 2022
@openjdk
Copy link

openjdk bot commented Apr 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 18, 2022
@openjdk
Copy link

openjdk bot commented Apr 20, 2022

@erikj79 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8079087: Add support for Cygwin 2.0
8176033: New cygwin grep does not match \r as newline
8179675: Build with error on windows with new Cygwin grep

Reviewed-by: iris, tbell

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 20, 2022
@erikj79
Copy link
Member Author

erikj79 commented Apr 29, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 29, 2022

Going to push as commit a30a007.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 3740d05: 8285400: Add '@APinote' to the APIs defined in Java SE 8 MR 3
  • 58ec25d: 8201793: (ref) Reference object should not support cloning
  • 330d63d: 8175797: (ref) Reference::enqueue method should clear the reference object before enqueuing
  • ad6cdea: 8071507: (ref) Clear phantom reference as soft and weak references do
  • d63ed0a: 8284907: Compact profiles build fails with GNU make 4

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 29, 2022
@openjdk openjdk bot closed this Apr 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@erikj79 Pushed as commit a30a007.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants