Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8175797: (ref) Reference::enqueue method should clear the reference object before enqueuing #5

Closed
wants to merge 1 commit into from

Conversation

poonamparhar
Copy link
Member

@poonamparhar poonamparhar commented Apr 20, 2022

These changes backport the following fixes to jdk8u-ri:

  • 8175797: (ref) Reference::enqueue method should clear the reference object before enqueuing
  • 8178832: (ref) jdk.lang.ref.disableClearBeforeEnqueue property is ignored
  • 8193780: (ref) Remove the undocumented jdk.lang.ref.disableClearBeforeEnqueue system property

With this fix, the enqueue method clears the reference before enqueuing it to the registered queue.

The backport of changes to the file jdk/test/java/lang/ref/ReferenceEnqueue.java needed some manual adjustment. Apart from that, backport of changes to the rest of the files are exact match with the original fixes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8175797: (ref) Reference::enqueue method should clear the reference object before enqueuing ⚠️ Issue is not open.
  • JDK-8178832: (ref) jdk.lang.ref.disableClearBeforeEnqueue property is ignored ⚠️ Issue is not open.
  • JDK-8193780: (ref) Remove the undocumented "jdk.lang.ref.disableClearBeforeEnqueue" system property ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-ri pull/5/head:pull/5
$ git checkout pull/5

Update a local copy of the PR:
$ git checkout pull/5
$ git pull https://git.openjdk.java.net/jdk8u-ri pull/5/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5

View PR using the GUI difftool:
$ git pr show -t 5

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-ri/pull/5.diff

@poonamparhar
Copy link
Member Author

poonamparhar commented Apr 20, 2022

/issue add JDK-8178832
/issue add JDK-8193780

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 20, 2022

👋 Welcome back poonam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 20, 2022
@openjdk
Copy link

openjdk bot commented Apr 20, 2022

@poonamparhar
Adding additional issue to issue list: 8178832: (ref) jdk.lang.ref.disableClearBeforeEnqueue property is ignored.

@openjdk
Copy link

openjdk bot commented Apr 20, 2022

@poonamparhar
Adding additional issue to issue list: 8193780: (ref) Remove the undocumented "jdk.lang.ref.disableClearBeforeEnqueue" system property.

@mlbridge
Copy link

mlbridge bot commented Apr 20, 2022

Webrevs

Copy link
Member

@mlchung mlchung left a comment

Looks good. This patch is equivalent to 8175797 with the system property dropped.

@openjdk
Copy link

openjdk bot commented Apr 20, 2022

@poonamparhar This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8175797: (ref) Reference::enqueue method should clear the reference object before enqueuing
8178832: (ref) jdk.lang.ref.disableClearBeforeEnqueue property is ignored
8193780: (ref) Remove the undocumented "jdk.lang.ref.disableClearBeforeEnqueue" system property

Reviewed-by: mchung, kbarrett, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 20, 2022
Copy link

@kimbarrett kimbarrett left a comment

Looks good.

Copy link
Member

@irisclark irisclark left a comment

Spec changes look good.

@poonamparhar
Copy link
Member Author

poonamparhar commented Apr 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 28, 2022

Going to push as commit 330d63d.
Since your change was applied there have been 2 commits pushed to the master branch:

  • ad6cdea: 8071507: (ref) Clear phantom reference as soft and weak references do
  • d63ed0a: 8284907: Compact profiles build fails with GNU make 4

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 28, 2022
@openjdk openjdk bot closed this Apr 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 28, 2022
@openjdk
Copy link

openjdk bot commented Apr 28, 2022

@poonamparhar Pushed as commit 330d63d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
4 participants