8201793: (ref) Reference object should not support cloning

[poonamparhar]

This changeset backports the fix for 8201793 to jdk8u-ri.

With this change, java.lang.ref.Reference::clone method always throws CloneNotSupportedException.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed
• Change requires a CSR request to be approved

Issues

• JDK-8201793: (ref) Reference object should not support cloning
• JDK-8202260: (ref) Reference objects should not support cloning (CSR)

Reviewers

• Mandy Chung (@mlchung - Reviewer) ⚠️ Review applies to a096694
• Kim Barrett (@kimbarrett - no project role) ⚠️ Review applies to 365622e
• Iris Clark (@irisclark - Author) ⚠️ Review applies to a096694

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-ri pull/6/head:pull/6
$ git checkout pull/6

Update a local copy of the PR:
$ git checkout pull/6
$ git pull https://git.openjdk.java.net/jdk8u-ri pull/6/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6

View PR using the GUI difftool:
$ git pr show -t 6

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-ri/pull/6.diff

[bridgekeeper]

👋 Welcome back poonam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full (2014116a)
• 01: Full - Incremental (a0966941)
• 00: Full (365622e1)

[mlchung]

Looks good. The only diff from the original fix is @since 8 as this is for 8u RI.

[openjdk]

@poonamparhar This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8201793: (ref) Reference object should not support cloning

Reviewed-by: mchung, kbarrett, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kimbarrett]

Looks good.

[mlchung]

This method is only present in JDK 8u42 (RI) and 8u352 and later releases. It's not in existing 8u releases >= 8u45 and < 8u352. Neither 8 or 8u42 would cause confusion. A suggestion is to use @apiNote to indicate which MR this method is defined:

@apiNote This method is defined in Java SE 8 Maintenance Release 4.

[irisclark]

The proposed @apinote looks good.

[irisclark]

The proposed spec changes look good with the addition of the proposed @APinote.

[irisclark]

The proposed @apinote looks good.

[irisclark]

Updated @APinote looks good.

[poonamparhar]

/integrate

[openjdk]

Going to push as commit 58ec25d.

[openjdk]

@poonamparhar Pushed as commit 58ec25d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.