Skip to content
This repository was archived by the owner on Oct 1, 2025. It is now read-only.

8285400: Add '@apiNote' to the APIs defined in Java SE 8 MR 3 #7

Closed
wants to merge 3 commits into from
Closed

8285400: Add '@apiNote' to the APIs defined in Java SE 8 MR 3 #7

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ead32fc
8285400: Add '@apiNote' to the APIs defined in Java SE 8 MR 3
poonamparhar Apr 25, 2022
7cdcb51
addressed the review comments
poonamparhar Apr 26, 2022
0006dac
updated copyrights
poonamparhar Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions jdk/src/share/classes/java/security/Signature.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,6 @@ public final void initVerify(Certificate certificate)
* supposed to be used for digital signatures, an
* {@code InvalidKeyException} is thrown.
*
* @apiNote This method is defined in Java SE 8 Maintenance Release 3.
* @param certificate the certificate of the identity whose signature is
* going to be verified.
* @param params the parameters used for verifying this signature.
Expand All @@ -593,8 +592,6 @@ public final void initVerify(Certificate certificate)
* is not encoded properly or does not include required parameter
* information or cannot be used for digital signature purposes.
* @exception InvalidAlgorithmParameterException if the params is invalid.
*
* @since 8
*/
final void initVerify(Certificate certificate,
AlgorithmParameterSpec params)
Expand Down
6 changes: 6 additions & 0 deletions jdk/src/share/classes/java/security/spec/MGF1ParameterSpec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,18 @@ public class MGF1ParameterSpec implements AlgorithmParameterSpec {

/**
* The MGF1ParameterSpec which uses SHA-512/224 message digest
*
* @apiNote This field is defined in Java SE 8 Maintenance Release 3.
* @since 8
*/
public static final MGF1ParameterSpec SHA512_224 =
new MGF1ParameterSpec("SHA-512/224");

/**
* The MGF1ParameterSpec which uses SHA-512/256 message digest
*
* @apiNote This field is defined in Java SE 8 Maintenance Release 3.
* @since 8
*/
public static final MGF1ParameterSpec SHA512_256 =
new MGF1ParameterSpec("SHA-512/256");
Expand Down
1 change: 1 addition & 0 deletions jdk/src/share/classes/java/security/spec/PSSParameterSpec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ public class PSSParameterSpec implements AlgorithmParameterSpec {
/**
* The {@code TrailerFieldBC} constant as defined in PKCS#1
*
* @apiNote This field is defined in Java SE 8 Maintenance Release 3.
* @since 8
*/
public static final int TRAILER_FIELD_BC = 1;
Expand Down
4 changes: 2 additions & 2 deletions jdk/src/share/classes/javax/net/ssl/SSLEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1353,8 +1353,8 @@ public String getHandshakeApplicationProtocol() {
* }</pre>
*
* @apiNote This method is defined in Java SE 8 Maintenance Release 3.
*
* It should be called by TLS server applications before the TLS
* <p>
* This method should be called by TLS server applications before the TLS
* handshake begins. Also, this {@code SSLEngine} should be configured with
* parameters that are compatible with the application protocol selected by
* the callback function. For example, enabling a poor choice of cipher
Expand Down
4 changes: 2 additions & 2 deletions jdk/src/share/classes/javax/net/ssl/SSLSocket.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,8 +763,8 @@ public String getHandshakeApplicationProtocol() {
* }</pre>
*
* @apiNote This method is defined in Java SE 8 Maintenance Release 3.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concern here about either a second @apiNote or a separator.

*
* It should be called by TLS server applications before the TLS
* <p>
* This method should be called by TLS server applications before the TLS
* handshake begins. Also, this {@code SSLSocket} should be configured with
* parameters that are compatible with the application protocol selected by
* the callback function. For example, enabling a poor choice of cipher
Expand Down