8290832: It is no longer possible to change "user.dir" in the JDK8

[mrserb]

This is the request to revert the fix for JDK-8194154 integrated to the openjdk8u342

The fix for JDK-8194154 disabled the possibility to change the "user.dir" property.
Changing the "user.dir" was not recommended from the beginning but it was not forbidden, so there are some old applications that rely on the old behavior.

For compatibility reasons, it would be good to restore the old behavior.

This PR reverts this commit: 5fcfb7a

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290832: It is no longer possible to change "user.dir" in the JDK8

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u pull/14/head:pull/14
$ git checkout pull/14

Update a local copy of the PR:
$ git checkout pull/14
$ git pull https://git.openjdk.org/jdk8u pull/14/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14

View PR using the GUI difftool:
$ git pr show -t 14

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/14.diff

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (4502400a)

[phohensee]

Copyright dates need to be reverted in UnixFileSystem.java and WinNTFileSystem.java. Other than that, lgtm.

[gnu-andrew]

Copyright dates need to be reverted in UnixFileSystem.java and WinNTFileSystem.java. Other than that, lgtm.

Yes, I did wonder why those were omitted myself. It should just be a simple git revert <id>, no?

[gnu-andrew]

@mrserb can you turn on Actions for this repo? I know we already tested this on 8u-dev but it would be good to get those enabled for any future critical fixes that need to go direct to 8u.

If one of you could review #15 that will need to go in before this so it resolves against the right release.

[mrserb]

Copyright dates need to be reverted in UnixFileSystem.java and WinNTFileSystem.java. Other than that, lgtm.

Yes, I did wonder why those were omitted myself. It should just be a simple git revert <id>, no?

That dates were changed later, the fix in question changed them to 2018, but now they are 2022 due to other fixes.

[phohensee]

In that case, lgtm.

[mrserb]

@mrserb can you turn on Actions for this repo? I know we already tested this on 8u-dev but it would be good to get those enabled for any future critical fixes that need to go direct to 8u.

I think Github disabled those actions since the changes in this repo rarely happen.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8290832: It is no longer possible to change "user.dir" in the JDK8

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 244f98e: 8291568: Bump update version of OpenJDK: 8u345

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mrserb]

actions executed.

[gnu-andrew]

Ah, right, sorry I should have checked the current state of the files. Both were updated by the security fix JDK-8278356.

I've approved the bug (flipped it to a jdk8u-critical-fix/yes to reflect it going direct to 8u, not 8u-dev) and the release bump is in now, so this is good to go.

[gnu-andrew]

actions executed.

Thanks. Strange that it would disable them, I've not heard of that before.

[mrserb]

/integrate

[openjdk]

Going to push as commit 2dadc2b.
Since your change was applied there has been 1 commit pushed to the master branch:

• 244f98e: 8291568: Bump update version of OpenJDK: 8u345

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit 2dadc2b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.