Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8028265: Add legacy tz tests to OpenJDK #20

Closed
wants to merge 1 commit into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Sep 16, 2022

This is a clean backport of JDK-8028265, other than moving the tests from test/jdk to jdk/test.

All tests pass with current 8u. AssureTzdataVersion also successfully caught version mismatches between the local tree's 2022a and 2021e in an old build, and 2022c in my system build that already has updated system tzdata

Applying for this as a critical fix as it's a pre-requisite for JDK-8292579, the update to 2022c


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u pull/20/head:pull/20
$ git checkout pull/20

Update a local copy of the PR:
$ git checkout pull/20
$ git pull https://git.openjdk.org/jdk8u pull/20/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20

View PR using the GUI difftool:
$ git pr show -t 20

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/20.diff

@gnu-andrew
Copy link
Member Author

/clean

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 16, 2022

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 92deab546549ca549408a983fe361d9536d2cd37 8028265: Add legacy tz tests to OpenJDK Sep 16, 2022
@openjdk
Copy link

openjdk bot commented Sep 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Sep 16, 2022
@openjdk openjdk bot added rfr Pull request is ready for review clean labels Sep 16, 2022
@openjdk
Copy link

openjdk bot commented Sep 16, 2022

@gnu-andrew This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Sep 16, 2022

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8028265: Add legacy tz tests to OpenJDK

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 16, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 16, 2022

Webrevs

@gnu-andrew
Copy link
Member Author

Tests look good (Windows failure is a download failure on release build only) and I see jdk8u-critical-yes

@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 16, 2022

Going to push as commit e2cbfd5.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 16, 2022
@openjdk openjdk bot closed this Sep 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2022
@openjdk
Copy link

openjdk bot commented Sep 16, 2022

@gnu-andrew Pushed as commit e2cbfd5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

DingliZhang pushed a commit to DingliZhang/jdk8u that referenced this pull request Jun 25, 2023
…INLINE

Fix the error OS_CPU_HEADER_INLINE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant