-
Notifications
You must be signed in to change notification settings - Fork 229
8028265: Add legacy tz tests to OpenJDK #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/clean |
|
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@gnu-andrew This backport pull request is now marked as clean |
|
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Tests look good (Windows failure is a download failure on release build only) and I see |
|
/integrate |
|
Going to push as commit e2cbfd5. |
|
@gnu-andrew Pushed as commit e2cbfd5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
…INLINE Fix the error OS_CPU_HEADER_INLINE
This is a clean backport of JDK-8028265, other than moving the tests from
test/jdktojdk/test.All tests pass with current 8u.
AssureTzdataVersionalso successfully caught version mismatches between the local tree's 2022a and 2021e in an old build, and 2022c in my system build that already has updated system tzdataApplying for this as a critical fix as it's a pre-requisite for JDK-8292579, the update to 2022c
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u pull/20/head:pull/20$ git checkout pull/20Update a local copy of the PR:
$ git checkout pull/20$ git pull https://git.openjdk.org/jdk8u pull/20/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20View PR using the GUI difftool:
$ git pr show -t 20Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/20.diff