8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled

[alexeybakhtin]

Backported as a follow-on issue for JDK-8269039

Based on the JDK11u patch
I had to resolve some merge issues in a few places:

TimestampCheck.java - simple merge because of no JDK-8171319 in JDK8
ManifestEntryVerifier.java - Manually updated because of different arguments of the permits() method
DisabledAlgorithmConstraints.java - permits() method manually updated because of no JDK-8285398
SignerInfo.java - use explicit type instead of var
All corresponding tests passed

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u pull/24/head:pull/24
$ git checkout pull/24

Update a local copy of the PR:
$ git checkout pull/24
$ git pull https://git.openjdk.org/jdk8u pull/24/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24

View PR using the GUI difftool:
$ git pr show -t 24

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/24.diff

[bridgekeeper]

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (0f4bfd5c)

[phohensee]

Please configure pre-submit testing on your repo. Other than that, lgtm.

[openjdk]

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[gnu-andrew]

Backport looks good to me.

The text "the value is a record" is wrong, given the change from a record to AlgorithmInfo, but that mistake was also in the 11u version so this backport isn't the place to fix it. It's a internal class so I don't think it matters much anyway.

[gnu-andrew]

Added jdk8u-critical-yes for approval.

[alexeybakhtin]

/integrate

[openjdk]

Going to push as commit 53620b3.
Since your change was applied there has been 1 commit pushed to the master branch:

• 7297bdf: 8296108: (tz) Update Timezone Data to 2022f

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeybakhtin Pushed as commit 53620b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[alexeybakhtin]

@gnu-andrew Thank you for the review.
Should I close the PR for the jdk8u-dev repo without committing?
Or it should be completed as usual with jdk8u-fix-request label?

[gnu-andrew]

Please close the 8u-dev PR. We'll merge the next build promotion with this change back into 8u-dev.