Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296108: (tz) Update Timezone Data to 2022f #25

Closed

Conversation

dimitryc
Copy link

@dimitryc dimitryc commented Nov 30, 2022

The same as openjdk/jdk8u-dev#200

It's created against jdk8u so that this update can be included in 8u362.

All relevant tests passed jdk/test/java/util/TimeZone, jdk/test/sun/util/calendar and jdk/test/java/time/test


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u pull/25/head:pull/25
$ git checkout pull/25

Update a local copy of the PR:
$ git checkout pull/25
$ git pull https://git.openjdk.org/jdk8u pull/25/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25

View PR using the GUI difftool:
$ git pr show -t 25

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/25.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2022

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9d3b4ef2ad658afb5379796b7224458c12c81f5d 8296108: (tz) Update Timezone Data to 2022f Nov 30, 2022
@openjdk
Copy link

openjdk bot commented Nov 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Nov 30, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 30, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 30, 2022

Webrevs

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the patch against the 11u version and the rearguard tzdata2022f, and it looks fine.

Please label the bug with jdk8u-critical-request and add an approval request comment.

@openjdk
Copy link

openjdk bot commented Nov 30, 2022

@dimitryc This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8296108: (tz) Update Timezone Data to 2022f

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 30, 2022
@dimitryc
Copy link
Author

Verified the patch against the 11u version and the rearguard tzdata2022f, and it looks fine.

Please label the bug with jdk8u-critical-request and add an approval request comment.

Thanks for verifying. Added jdk8u-critical-request and new approval request comment.

@gnu-andrew
Copy link
Member

Thanks. Approved for 8u.

@dimitryc
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 30, 2022

Going to push as commit 7297bdf.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 30, 2022
@openjdk openjdk bot closed this Nov 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 30, 2022
@openjdk
Copy link

openjdk bot commented Nov 30, 2022

@dimitryc Pushed as commit 7297bdf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants